Repository navigation
feat(security): shared CEI path analysis and token/SAC reentrancy findings (#336 #310 #325) - #1024
Open
woahwhattheheck wants to merge 8 commits into
Conversation
…ots (Centurylong#336 Centurylong#310 Centurylong#325) Apply source-preserving formatting, rule index and differential mapping updates, with token and SAC reentrancy golden snapshot fixtures. The focused Rust validation reported for these exact changes remains the prior evidence; no new tests or build are asserted. Original issue contributors and the conditional GrantFox compensation request remain preserved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the change
Adds a shared checks-effects-interactions model and a default CEI detector for the three related issues below. The model separates conditional paths, records bounded loop paths, and reports an interaction that precedes a storage effect on the same syntactic path. Token/SAC client calls are included alongside host contract calls.
The existing contribution now includes the detector index, differential rule mapping, and golden snapshot coverage, across twelve files.
Fixes / Closes
Closes #336
Closes #310
Closes #325
/claim #336
/claim #310
/claim #325
Motivation and context
CeiModelAPI with ordered effects and interactions.SANCT_CEIfinding and its remediation documentation.transferandtransfer_from.This is bounded syntactic analysis. Closures, cross-function effects, dynamic dispatch, and unrecognized storage aliases are outside its scope; it is not a whole-program proof.
Dependencies
No new runtime dependency. Retained validation used the repository-pinned Rust 1.85.0 with default features disabled. The SMT/all-features configuration, full crate suite, and CLI remain unverified by that validation.
Type of change
How Has This Been Tested?
The retained validation handoff reports:
--no-default-features.These are the prior implementation/validation results. Publication verified the existing branch and its twelve-file diff; no tests or builds were rerun during submission. No all-features, full-suite, or hosted-CI success is asserted.
Checklist
GrantFox compensation request
I request sponsor review, acceptance, and applicable GrantFox OSS / Official Campaign bounty compensation for #336, #310, and #325 as the original @woahwhattheheck contributor. Please apply the sponsor/platform rules for per-issue eligibility and allocation, and process the reward payment for each accepted eligible issue to @woahwhattheheck. Please let me know if additional payout registration is required.
All three issues are labeled Maybe Rewarded; this affirmative payment request does not assume a fixed amount or an already granted award.
Source carrier: woahwhattheheck#15