fix: polymarket-us hub row links to external instead of 404 - #1708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
polymarket-us has volume data tracked via pm-cohort-stats but is not probed by the bench harness — no entry in any bench YAML — so /products/polymarket-us 404s (getProvider returns null).
Fix: added
benched: boolean+externalUrl?: stringto VenueSeed/PmVenueRow. polymarket-us is the only hub-only venue (benched: false). The leaderboard now links to externalUrl in a new tab for unbenched venues instead of /products.All other venues (manifold, predictit, smarkets, metaculus) default to benched: true and keep their /products links.
The "Off chain" label is correct — polymarketexchange.com is a CFTC contract market that operates outside the Polygon blockchain, unlike polymarket.com.