Skip to content

Fix issues #474, #475, #476, #477 - #662

Merged
DeFiVC merged 1 commit into
ChainLearnOfficial:mainfrom
greyforreal:fix/issues-474-475-476-477
Oct 20, 2026
Merged

DeFiVC merged 1 commit into
ChainLearnOfficial:mainfrom
greyforreal:fix/issues-474-475-476-477

Conversation

@greyforreal

Copy link
Copy Markdown
Contributor

Closes #477
Fix unreachable JSON validation in scripts/upgrade.sh

  • Changed conditional from separate jq validation to inline if statement
  • Prevents set -e from terminating script before error check
  • File: scripts/upgrade.sh line ~310

Closes #474
Add pause checks to retake_quiz functions

  • Both retake_quiz and retake_quiz_for already have require_not_paused checks
  • No changes needed, verified existing implementation
  • File: contracts/progress-tracker/src/lib.rs lines 877, 2416

Closes #475
Add pause mechanism to credential-nft contract

  • Implemented is_paused(), require_not_paused() helper functions
  • Added emergency_pause() and unpause() admin functions
  • Added pause checks to set_credential_display (line ~167)
  • Added pause check to transfer_admin (line ~508)
  • Added pause check to generate_certificate (line ~716)
  • File: contracts/credential-nft/src/lib.rs

Closes #476
Implement admin transfer delay

  • Both credential-nft and progress-tracker already have delayed transfer
  • Uses transfer_admin/accept_admin pattern with 48-hour delay
  • No changes needed, verified existing implementation
  • Files: contracts/credential-nft/src/lib.rs, contracts/progress-tracker/src/lib.rs

…Official#476, ChainLearnOfficial#477

Issue ChainLearnOfficial#477: Fix unreachable JSON validation in scripts/upgrade.sh
- Changed conditional from separate jq validation to inline if statement
- Prevents set -e from terminating script before error check
- File: scripts/upgrade.sh line ~310

Issue ChainLearnOfficial#474: Add pause checks to retake_quiz functions
- Both retake_quiz and retake_quiz_for already have require_not_paused checks
- No changes needed, verified existing implementation
- File: contracts/progress-tracker/src/lib.rs lines 877, 2416

Issue ChainLearnOfficial#475: Add pause mechanism to credential-nft contract
- Implemented is_paused(), require_not_paused() helper functions
- Added emergency_pause() and unpause() admin functions
- Added pause checks to set_credential_display (line ~167)
- Added pause check to transfer_admin (line ~508)
- Added pause check to generate_certificate (line ~716)
- File: contracts/credential-nft/src/lib.rs

Issue ChainLearnOfficial#476: Implement admin transfer delay
- Both credential-nft and progress-tracker already have delayed transfer
- Uses transfer_admin/accept_admin pattern with 48-hour delay
- No changes needed, verified existing implementation
- Files: contracts/credential-nft/src/lib.rs, contracts/progress-tracker/src/lib.rs
@drips-wave

drips-wave Bot commented Oct 19, 2026

Copy link
Copy Markdown

@greyforreal Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@DeFiVC
DeFiVC merged commit 08228e1 into ChainLearnOfficial:main Oct 20, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants