Repository navigation
Fix issues #474, #475, #476, #477 - #662
Merged
DeFiVC merged 1 commit intoOct 20, 2026
Merged
Conversation
…Official#476, ChainLearnOfficial#477 Issue ChainLearnOfficial#477: Fix unreachable JSON validation in scripts/upgrade.sh - Changed conditional from separate jq validation to inline if statement - Prevents set -e from terminating script before error check - File: scripts/upgrade.sh line ~310 Issue ChainLearnOfficial#474: Add pause checks to retake_quiz functions - Both retake_quiz and retake_quiz_for already have require_not_paused checks - No changes needed, verified existing implementation - File: contracts/progress-tracker/src/lib.rs lines 877, 2416 Issue ChainLearnOfficial#475: Add pause mechanism to credential-nft contract - Implemented is_paused(), require_not_paused() helper functions - Added emergency_pause() and unpause() admin functions - Added pause checks to set_credential_display (line ~167) - Added pause check to transfer_admin (line ~508) - Added pause check to generate_certificate (line ~716) - File: contracts/credential-nft/src/lib.rs Issue ChainLearnOfficial#476: Implement admin transfer delay - Both credential-nft and progress-tracker already have delayed transfer - Uses transfer_admin/accept_admin pattern with 48-hour delay - No changes needed, verified existing implementation - Files: contracts/credential-nft/src/lib.rs, contracts/progress-tracker/src/lib.rs
|
@greyforreal Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #477
Fix unreachable JSON validation in scripts/upgrade.sh
Closes #474
Add pause checks to retake_quiz functions
Closes #475
Add pause mechanism to credential-nft contract
Closes #476
Implement admin transfer delay