Skip to content

fix(ui): delete-author dialog lists every author folder, not only the legacy path #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jordanfelle wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix(ui): delete-author dialog lists every author folder, not only the legacy path #269

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aed4c2c
fix(ui): delete-author dialog lists every author folder, not only the…
jordanfelle Sep 29, 2026
036b19a
fix(ui): read the author's real folder fields (audiobookFolder / eboo…
jordanfelle Sep 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 34 additions & 11 deletions frontend/src/Author/Delete/DeleteAuthorModalContent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,20 @@ class DeleteAuthorModalContent extends Component {
const {
authorName,
path,
audiobookFolder,
ebookFolder,
statistics,
onModalClose
} = this.props;

// An author can have a separate audiobook and ebook folder (plus the legacy single path). Deleting
// with "delete files" removes all of them, so list every distinct one instead of only `path`.
// The API exposes the format folders as audiobookFolder / ebookFolder (AuthorResource) - not
// audiobookPath / ebookPath, which are null on the resource.
const paths = [path, audiobookFolder, ebookFolder]
.filter((folder) => !!folder && folder.trim() !== '')
.filter((folder, index, all) => all.indexOf(folder) === index);

const {
bookFileCount,
sizeOnDisk
Expand All @@ -93,14 +103,21 @@ class DeleteAuthorModalContent extends Component {
</ModalHeader>

<ModalBody>
<div className={styles.pathContainer}>
<Icon
className={styles.pathIcon}
name={icons.FOLDER}
/>

{path}
</div>
{
paths.map((folder) => (
<div
key={folder}
className={styles.pathContainer}
>
<Icon
className={styles.pathIcon}
name={icons.FOLDER}
/>

{folder}
</div>
))
}

<FormGroup>
<FormLabel>{deleteFilesLabel}</FormLabel>
Expand Down Expand Up @@ -149,9 +166,13 @@ class DeleteAuthorModalContent extends Component {
{
deleteFiles &&
<div className={styles.deleteFilesMessage}>
<div>
{translate('TheAuthorFolderAndAllOfItsContentWillBeDeleted', [path])}
</div>
{
paths.map((folder) => (
<div key={folder}>
{translate('TheAuthorFolderAndAllOfItsContentWillBeDeleted', [folder])}
</div>
))
}

{
!!bookFileCount &&
Expand Down Expand Up @@ -182,6 +203,8 @@ class DeleteAuthorModalContent extends Component {
DeleteAuthorModalContent.propTypes = {
authorName: PropTypes.string.isRequired,
path: PropTypes.string.isRequired,
audiobookFolder: PropTypes.string,
ebookFolder: PropTypes.string,
statistics: PropTypes.object.isRequired,
onDeletePress: PropTypes.func.isRequired,
onModalClose: PropTypes.func.isRequired
Expand Down