Skip to content

fix(ui): stop the book page refetching forever for a book that does not exist #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jordanfelle wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix(ui): stop the book page refetching forever for a book that does not exist #272

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0cd0492
fix(ui): stop the book page refetching forever for a book that does n…
jordanfelle Sep 29, 2026
4e83dd5
Retry non-404 failures a few times instead of blocking every retry
jordanfelle Sep 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 36 additions & 2 deletions frontend/src/Book/Details/BookDetailsPageConnector.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,9 @@ function findBookByRouteSlug(items, routeBookKey, scopedMediaType) {
return matches.sort((left, right) => left.id - right.id)[0];
}

// Max fetches of one book per route: the first try plus retries for non-404 failures.
const MAX_BOOK_FETCH_ATTEMPTS = 3;

function createMapStateToProps() {
return createSelector(
(state, { match }) => match,
Expand All @@ -58,6 +61,7 @@ function createMapStateToProps() {
const isNumericRoute = isNumericBookRoute(routeBookKey);
const numericBookId = isNumericRoute ? parseInt(routeBookKey) : null;
const isFetching = books.isFetching || author.isFetching;
const booksError = books.error;

// Find the book if it exists
const book = isNumericRoute ?
Expand Down Expand Up @@ -86,6 +90,7 @@ function createMapStateToProps() {
siblingCount,
needsBookFetch,
needsAuthorFetch,
booksError,
isFetching,
isPopulated: hasBook && !needsAuthorFetch
};
Expand All @@ -104,6 +109,9 @@ class BookDetailsPageConnector extends Component {
super(props);
this.state = { hasMounted: false };
this._lastSiblingFetchKey = null;
this._lastBookFetchKey = null;
this._bookFetchAttempts = 0;
this._lastAuthorFetchKey = null;
}
//
// Lifecycle
Expand Down Expand Up @@ -135,13 +143,36 @@ class BookDetailsPageConnector extends Component {
scopedMediaType,
needsBookFetch,
needsAuthorFetch,
booksError,
authorId,
book,
bookMediaType,
siblingCount
} = this.props;

if (needsBookFetch && routeBookKey) {
// Do not refetch forever. When the book does not exist the server answers 404, the fetch fails
// and `isFetching` drops back to false while the book is still missing, so `needsBookFetch` flips
// false -> true again and componentDidUpdate calls populate() again: an endless loop of failing
// requests with the spinner up most of the time, and the "cannot be found" screen below never
// gets to render.
//
// A definitive 404 is final. Anything else (a transient 500, a network error, a request aborted by
// another fetchBooks, an empty 200) is retried, but only a few times so a persistent failure still
// ends on the "cannot be found" screen instead of looping.
const bookFetchKey = `${routeBookKey}|${scopedMediaType || ''}`;
const isNewBookKey = this._lastBookFetchKey !== bookFetchKey;

if (isNewBookKey) {
this._lastBookFetchKey = bookFetchKey;
this._bookFetchAttempts = 0;
}

const lastFetchWasNotFound = !!booksError && booksError.status === 404;
const canRetryBookFetch = !isNewBookKey && !lastFetchWasNotFound && this._bookFetchAttempts < MAX_BOOK_FETCH_ATTEMPTS;

if (needsBookFetch && routeBookKey && (isNewBookKey || canRetryBookFetch)) {
this._bookFetchAttempts++;

// Fetch the specific book data. bookId may be either the local numeric id
// or a Readarr-compatible titleSlug from an external service link.
const fetchParams = { bookId: routeBookKey.toString() };
Expand All @@ -153,7 +184,9 @@ class BookDetailsPageConnector extends Component {
this.props.fetchBooks(fetchParams);
}

if (needsAuthorFetch && authorId) {
if (needsAuthorFetch && authorId && this._lastAuthorFetchKey !== authorId) {
this._lastAuthorFetchKey = authorId;

// Fetch the author data
this.props.fetchAuthor({ id: authorId });
}
Expand Down Expand Up @@ -237,6 +270,7 @@ BookDetailsPageConnector.propTypes = {
bookMediaType: PropTypes.string,
siblingCount: PropTypes.number,
needsBookFetch: PropTypes.bool,
booksError: PropTypes.object,
needsAuthorFetch: PropTypes.bool,
match: PropTypes.shape({ params: PropTypes.shape({ bookId: PropTypes.string.isRequired }).isRequired }).isRequired,
fetchBooks: PropTypes.func.isRequired,
Expand Down