Replace identifier skip checkboxes with a select that matches the filter's behavior - #277
Closed
bhoffman20 wants to merge 1 commit into
Closed
bhoffman20 wants to merge 1 commit into
bhoffman20 wants to merge 1 commit into
Conversation
… list to make behaviors more clear
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces the "Skip audiobooks/books missing identifier" and "Skip audiobooks/books missing ASIN" checkboxes in the metadata profile editor with a single select list.
Ticked together, the two checkboxes did something neither label described.
EditionMetadataProfileFilter.MeetsIdentifierRequirementskeeps an edition based on the combination of the two flags:skipMissingIsbnskipMissingAsinWith both boxes ticked, an ISBN became mandatory, even though the "missing identifier" help text said "ISBN or ASIN". Audible-only editions rarely carry an ISBN, so they were silently pruned during refresh. For example, the Elizabeth Evans narrations of Sarah J. Maas's A Court of Thorns and Roses books were dropped.
This PR only changes the UI:
skipMissingIsbn/skipMissingAsinflags. The API, the backend filter and the database schema are unchanged, so existing profiles keep their behavior.IsProtectedEdition/MetadataProfileServicelocal-file protection).SkipMissingAsin*strings fromen.json; no other locale defines them.Fixes # (no existing issue)
Database Migration
NO
How was this tested?
On Ubuntu 25.10, building natively from source (.NET 10.0.401):
dotnet build src/Chaptarr.sln -c Release: 0 warnings, 0 errors.dotnet test --filter FullyQualifiedName~MetadataProfile: 38 passed, includingEditionMetadataProfileFilterFixture, which covers the flag combinations above.yarn buildandyarn typecheckpass.yarn check-translationsreports all keys present.eslinton the changed file is clean; the repo-wideyarn lintcount is unchanged fromdevelop(1309 pre-existing problems).skipMissingIsbn/skipMissingAsinvalues.Screenshots (UI changes only)
The metadata profile editor with the new select, closed and open:
List Collapsed:

List Open:
