Repository navigation
Add accessible names to Win11 Creator wizard controls - #5152
Merged
ChrisTitusTech merged 2 commits intoOct 21, 2026
Merged
ChrisTitusTech merged 2 commits into
ChrisTitusTech merged 2 commits into
Conversation
The Win11 Creator wizard (ChrisTitusTech#4925) was merged after the top-bar naming pass in ChrisTitusTech#4992/ChrisTitusTech#4993. Its glyph-only Back/Forward buttons report the Segoe MDL2 private-use character as their UI Automation name, and the ISO path box, the edition and USB combo boxes and the status log have an empty name because their visible labels are separate TextBlocks. Add AutomationProperties.Name to all six: "Previous Step" and "Next Step" for the arrows, and the visible label text for the other four. Cover them with a XAML test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Contributor
ChrisTitusTech
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
The Win11 Creator wizard from #4925 was merged after the top-bar naming pass in #4992/#4993, and six of its controls have no useful accessible name:
This adds
AutomationProperties.Nameto those six controls, the same way #4992 did for the top bar. The four inputs reuse their visible label text, and the arrow buttons are named "Previous Step" / "Next Step". The UI change is six XAML attributes with no behaviour change. One test inpester/xaml.Tests.ps1checks the six names.Verification:
pester/xaml.Tests.ps1,pester/generated-controls.Tests.ps1andpester/win11creator.Tests.ps1pass (58/58). The new test fails on the old XAML..\Compile.ps1succeeds.XamlReader.Load(without showing the window) and read each control's UI Automation name. Before the change the arrows report the glyph and the four inputs are empty. After the change they report the names above.Issue related to PR
🤖 Generated with Claude Code
Maintainer validation (2026-10-21)
Validated
fab9ab7e9f0207c2f21797f9c11813534e68ebeawith maind32efebmerged../Compile.ps1, generated-script parsing andgit diff --checkpassed; lint diagnostics reviewed with no actionable finding.codex review --base d32efebac6d50ce1a4e9734fb9400b884f76e7e6and independent skeptical-agent audit completed with no actionable findings on this head.