Skip to content

Add accessible names to Win11 Creator wizard controls - #5152

Merged
ChrisTitusTech merged 2 commits into
ChrisTitusTech:mainfrom
PanagiotisKaraliolios:a11y/win11creator-wizard-names
Oct 21, 2026
Merged

ChrisTitusTech merged 2 commits into
ChrisTitusTech:mainfrom
PanagiotisKaraliolios:a11y/win11creator-wizard-names

Conversation

@PanagiotisKaraliolios

@PanagiotisKaraliolios PanagiotisKaraliolios commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Type of Change

  • New feature
  • Bug fix
  • Documentation update
  • Refactor
  • UI/UX improvement

Description

The Win11 Creator wizard from #4925 was merged after the top-bar naming pass in #4992/#4993, and six of its controls have no useful accessible name:

  • WPFWin11ISOBackButton / WPFWin11ISOForwardButton: the content is a Segoe MDL2 glyph, so UI Automation reports the private-use character (U+E76B / U+E76C) as the name. The tooltip is only exposed as help text.
  • WPFWin11ISOPath, WPFWin11ISOEditionComboBox, WPFWin11ISOUSBDriveComboBox, WPFWin11ISOStatusLog: the visible "ISO file", "Windows edition", "USB drive" and "Status Log" labels are separate TextBlocks that aren't linked to the controls, so UI Automation reports an empty name for each one.

This adds AutomationProperties.Name to those six controls, the same way #4992 did for the top bar. The four inputs reuse their visible label text, and the arrow buttons are named "Previous Step" / "Next Step". The UI change is six XAML attributes with no behaviour change. One test in pester/xaml.Tests.ps1 checks the six names.

Verification:

  • pester/xaml.Tests.ps1, pester/generated-controls.Tests.ps1 and pester/win11creator.Tests.ps1 pass (58/58). The new test fails on the old XAML.
  • The full Pester suite (5.8.0, pwsh 7) gives 857 passed, 0 failed, 1 skipped (main: 856 / 0 / 1).
  • .\Compile.ps1 succeeds.
  • I loaded the XAML with XamlReader.Load (without showing the window) and read each control's UI Automation name. Before the change the arrows report the glyph and the four inputs are empty. After the change they report the names above.
  • I haven't checked this in Narrator or Accessibility Insights in the running app.

Issue related to PR

🤖 Generated with Claude Code

Maintainer validation (2026-10-21)

Validated fab9ab7e9f0207c2f21797f9c11813534e68ebea with main d32efeb merged.

  • Exact-head Windows CI: 963 Pester 5.8.0 tests passed, zero failures/skips; Script Analyzer job passed. CI evidence.
  • Local ./Compile.ps1, generated-script parsing and git diff --check passed; lint diagnostics reviewed with no actionable finding.
  • Full built-in codex review --base d32efebac6d50ce1a4e9734fb9400b884f76e7e6 and independent skeptical-agent audit completed with no actionable findings on this head.
  • Native Windows WPF loaded the full XAML and verified all six UI Automation peer names under Windows PowerShell 5.1 and PowerShell 7 in STA. Native WPF job. Narrator/Accessibility Insights and interactive navigation were not exercised.
  • No merge performed. Code-owner approval remains required.

The Win11 Creator wizard (ChrisTitusTech#4925) was merged after the top-bar naming
pass in ChrisTitusTech#4992/ChrisTitusTech#4993. Its glyph-only Back/Forward buttons report the
Segoe MDL2 private-use character as their UI Automation name, and the
ISO path box, the edition and USB combo boxes and the status log have
an empty name because their visible labels are separate TextBlocks.

Add AutomationProperties.Name to all six: "Previous Step" and "Next
Step" for the arrows, and the visible label text for the other four.
Cover them with a XAML test.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Repo admins can enable using credits for code reviews in their settings.

@github-actions github-actions Bot added bug Something isn't working ui update UI/UX improvements labels Oct 9, 2026
@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2404ace3-8568-4e0e-9cbb-fc626fa12061
📥 Commits

Reviewing files that changed from the base of the PR and between 07ccd8e and 29e25c1.

📒 Files selected for processing (2)
  • pester/xaml.Tests.ps1
  • xaml/inputXML.xaml

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

📝 Summary

Summary by CodeRabbit

  • Accessibility
    • Added accessible names to the Win11 ISO workflow’s navigation buttons, ISO path field, edition and USB drive selectors, and status log.

The Win11 Creator XAML now assigns automation names to six controls. A test checks that each control has its expected name.

Changes: Win11 Creator accessibility names

Layer / File(s) Summary
Control automation names and validation
xaml/inputXML.xaml, pester/xaml.Tests.ps1
The Back and Forward buttons, ISO path field, Windows edition selector, USB drive selector, and status log now have specified automation names. A test checks all six names.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: christitustech

Merge Risk: ⚪ Minimal · up to 29e25

The six wizard controls have the intended accessible names, and the added test covers them. No material merge risk is evident; the change appears ready for normal checks.

Pre-merge checks: Passed 5
Check name Status Explanation
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Title check Passed The title clearly and concisely identifies the main change: adding accessible names to Win11 Creator wizard controls.
Description check Passed The description directly explains the accessibility issue, the six XAML changes, the test coverage, and the verification results.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@ChrisTitusTech
ChrisTitusTech merged commit 467e001 into ChrisTitusTech:main Oct 21, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ui update UI/UX improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants