Skip to content

Fix flaky Cloud test_insert_finite_float_into_int - #1198

Merged
joe-clickhouse merged 1 commit into
mainfrom
polyglot/fix-flaky-finite-float-int-test
Nov 16, 2026
Merged

joe-clickhouse merged 1 commit into
mainfrom
polyglot/fix-flaky-finite-float-int-test

Conversation

@polyglotAI-bot

@polyglotAI-bot polyglotAI-bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes a flaky Cloud test.

The test used ENGINE Memory. On Cloud, each replica keeps its own Memory data. The SELECT can hit a replica that has no rows.

Use test_table_engine with ORDER BY id, like the other insert tests.

🤖 Generated with Claude Code


Note

Low Risk
Test-only change to table engine and DDL; no production or driver behavior is modified.

Overview
Fixes flaky test_insert_finite_float_into_int on ClickHouse Cloud by aligning table creation with other insert integration tests.

The test now takes the test_table_engine fixture (session-scoped MergeTree) instead of hardcoding ENGINE Memory, and adds ORDER BY id on create. On Cloud, Memory data is per-replica, so a follow-up SELECT could hit a replica that never received the insert; MergeTree with a sort key avoids that mismatch while keeping the same assertions on float-to-integer coercion.

Reviewed by Cursor Bugbot for commit b4ac3d9. Bugbot is set up for automated code reviews on this repo. Configure here.

Use the test_table_engine fixture instead of Memory. On Cloud, each replica
keeps its own Memory data, so the SELECT can miss the inserted rows.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

@security-ai-gate-reviewer security-ai-gate-reviewer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved by the AI review gate on b4ac3d9. Details in the approver's comment on this pull request.

@security-ai-gate-reviewer

Copy link
Copy Markdown

AI review gate — auto-approved

b4ac3d9583e5 is approved by security-ai-gate-reviewer[bot], an automated identity, not a human. The approval stands on the required AI review: Cursor Bugbot concluded green on this commit and the AI review gate is SUCCESS (its own comment has the verdict), and the change touches no path that requires a human reviewer. It is bound to this commit: a new push dismisses it and the approver re-evaluates.

History (latest 5 heads, newest first)

  • b4ac3d9583e5 approved — green: Cursor Bugbot

@joe-clickhouse

Copy link
Copy Markdown
Contributor

Had to close/open to retrigger ai gate.

@joe-clickhouse
joe-clickhouse merged commit 83f9397 into main Nov 16, 2026
153 of 156 checks passed
@joe-clickhouse
joe-clickhouse deleted the polyglot/fix-flaky-finite-float-int-test branch November 16, 2026 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants