Repository navigation
Fix flaky Cloud test_insert_finite_float_into_int - #1198
Merged
Merged
Conversation
Use the test_table_engine fixture instead of Memory. On Cloud, each replica keeps its own Memory data, so the SELECT can miss the inserted rows. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Auto-approved by the AI review gate on b4ac3d9. Details in the approver's comment on this pull request.
AI review gate — auto-approved
History (latest 5 heads, newest first)
|
joe-clickhouse
approved these changes
Nov 16, 2026
Contributor
|
Had to close/open to retrigger ai gate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a flaky Cloud test.
The test used
ENGINE Memory. On Cloud, each replica keeps its own Memory data. The SELECT can hit a replica that has no rows.Use
test_table_enginewithORDER BY id, like the other insert tests.🤖 Generated with Claude Code
Note
Low Risk
Test-only change to table engine and DDL; no production or driver behavior is modified.
Overview
Fixes flaky
test_insert_finite_float_into_inton ClickHouse Cloud by aligning table creation with other insert integration tests.The test now takes the
test_table_enginefixture (session-scopedMergeTree) instead of hardcodingENGINE Memory, and addsORDER BY idon create. On Cloud,Memorydata is per-replica, so a follow-upSELECTcould hit a replica that never received the insert;MergeTreewith a sort key avoids that mismatch while keeping the same assertions on float-to-integer coercion.Reviewed by Cursor Bugbot for commit b4ac3d9. Bugbot is set up for automated code reviews on this repo. Configure here.