Skip to content

docs: name the impact classes in the issue-priority skill - #1154

Open
polyglotAI-bot wants to merge 1 commit into
mainfrom
polyglot/issue-priority-impact-classes
Open

polyglotAI-bot wants to merge 1 commit into
mainfrom
polyglot/issue-priority-impact-classes

Conversation

@polyglotAI-bot

@polyglotAI-bot polyglotAI-bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Names four impact classes in .claude/skills/issue-priority/SKILL.md: Security, Data integrity, Stability, and Performance. The classes are the same in every ClickHouse client repository, so that issues are classified with the same words in each client. clickhouse-cpp, clickhouse-cs, and clickhouse-odbc get the same text in ClickHouse/clickhouse-cpp#613, ClickHouse/clickhouse-cs#743, and ClickHouse/clickhouse-odbc#615.

  • Section "2. Severity" starts with a table that defines the four impacts. An issue has none, one, or more of them.
  • Each severity row names the impact that puts an issue in the row.
  • The reason line records the impacts.

No priority level changes: each severity row keeps its conditions. How the classes change the priority is a later change.

No library code changes, so there is no changelog entry.

🤖 Generated with Claude Code


Note

Low Risk
Documentation-only triage guidance in a skill file; no runtime or priority-matrix behavior changes.

Overview
The issue-priority skill now requires triage to label issues with shared impact classes—Security, Data integrity, Stability, and Performance—before picking a severity row. A new table defines when each impact applies; most issues get no impact unless reproduction shows one.

Severity rows are unchanged in outcome but explicitly tie to those impacts (e.g. wrong data → Data integrity, hangs/crashes → Stability). The skill metadata and the one-line Reason format now include impacts (<impacts, or "no impact">), aligned with the same wording in other ClickHouse client repos. The base-level matrix and modifiers are untouched.

Reviewed by Cursor Bugbot for commit 89d42d5. Bugbot is set up for automated code reviews on this repo. Configure here.

The severity section now starts with four impact classes: Security, Data
integrity, Stability, and Performance. They are the same in every ClickHouse
client repository. Each severity row names the impact that puts an issue in
the row, and the reason line records the impacts. No priority level changes:
each row keeps its conditions.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@polyglotAI-bot
polyglotAI-bot requested review from a team, kavirajk and mshustov as code owners November 17, 2026 16:58
Copilot AI balanced review requested due to automatic review settings November 17, 2026 16:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are identified for this documentation-only update to impact terminology.

No open issues 🎉

What changed in this PR

This documentation-only PR standardizes impact terminology in the issue-priority skill without changing priority levels or library behavior.

Changes:

  • Defines four impact classes: Security, Data integrity, Stability, and Performance.
  • Connects impacts to the existing severity rows while preserving their conditions.
  • Adds impacts to the required reason line.
File Description
.claude/​skills/​issue-priority/​SKILL.md Defines impact classes, annotates severity guidance, and updates the skill description and reason format.

Review effort: Balanced

@security-ai-gate-reviewer security-ai-gate-reviewer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved by the AI review gate on 89d42d5. Details in the approver's comment on this pull request.

@security-ai-gate-reviewer

Copy link
Copy Markdown

AI review gate — auto-approved

89d42d56cb1d is approved by security-ai-gate-reviewer[bot], an automated identity, not a human. The approval stands on the required AI review: Cursor Bugbot concluded green on this commit and the AI review gate is SUCCESS (its own comment has the verdict), and the change touches no path that requires a human reviewer. It is bound to this commit: a new push dismisses it and the approver re-evaluates.

History (latest 5 heads, newest first)

  • 89d42d56cb1d approved — green: Cursor Bugbot

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants