Repository navigation
docs: rate speed requests and dependency CVEs; leaked secrets are vulnerabilities - #1156
Conversation
… are vulnerabilities
Review feedback (Bugbot on clickhouse-cpp#613):
- a request to make an operation faster has the impact Performance but
is a feature request ("Cosmetic, docs, feature"); only a Performance
defect uses "Workaround exists";
- authentication means how the client takes credentials; a secret that
leaks is a vulnerability, not authentication;
- a dependency with a published CVE or GHSA uses "Wrong data or
security" when the client calls the vulnerable code, else it is a
dependency update; an unpublished dependency vulnerability goes to the
private report.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit e6319e9)
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the documentation-only clarifications to issue classification and priority guidance.
No open issues 🎉
What changed in this PR
This documentation-only follow-up to #1155 aligns issue classification and priority guidance. It changes no library code or public APIs.
Changes:
- Rates performance improvement requests as features, while retaining defect-specific priority rules.
- Distinguishes credential handling from secret leaks, which are vulnerabilities.
- Clarifies priority rules for published dependency vulnerabilities and private reporting for unpublished flaws.
| File | Description |
|---|---|
.claude/skills/issue-priority/SKILL.md |
Clarifies severity rules for speed requests and published dependency vulnerabilities. |
.claude/skills/issue-classification/SKILL.md |
Refines security classifications and adds unpublished dependency flaws to private-report guidance. |
Review effort: Balanced
… in private Review feedback (Bugbot on clickhouse-odbc#615): the impact Security and the priority mapping named only a published CVE or GHSA, so an unpublished dependency vulnerability had no Security mapping; and the report to the dependency's maintainers did not say that it must be private. Both now cover a published or unpublished vulnerability, and the upstream report goes through the dependency's security policy, never a public issue. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Auto-approved by the AI review gate on 0a64bd3. Details in the approver's comment on this pull request.
AI review gate — auto-approved
History (latest 5 heads, newest first)
|
## Summary Follow-up to #1156 (merged). Review finding (Cursor Bugbot on ClickHouse/clickhouse-odbc#615, discussion r4619349461): the classification keeps every unpublished dependency vulnerability private, but the priority rule rated one in code that the client does not call as a public dependency update ("Cosmetic, docs, feature"), so triage could leave unpublished details on a public issue. - **Classification:** the impact Security names "a published one (CVE or GHSA) in code that the client calls, and any one that is not published yet". The list of "A vulnerability that is not public yet" says that an unpublished dependency vulnerability counts also in code that the client does not call. - **Priority:** a dependency vulnerability uses "Wrong data or security" when the client calls the vulnerable code, else "Cosmetic, docs, feature". A published one then asks for a dependency update in public; an unpublished one stays private also then, and the level is the proposed severity of the private report. The other client repositories get the same text. No library code changes, so there is no changelog entry. 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Documentation-only changes to agent triage skills; no runtime or security code paths are modified. > > **Overview** > Aligns **issue triage docs** so unpublished dependency vulnerabilities are never handled as public “dependency update” issues. > > **Classification** now states that **Security** covers published CVE/GHSA only when the client calls the vulnerable code, while **any** unpublished dependency vulnerability counts—even in code the client does not call—and must stay off public issues. **Priority** keeps `"Wrong data or security"` when vulnerable code is on the call path; when it is not, published CVEs can still be triaged publicly as `"Cosmetic, docs, feature"` (dependency bump), but unpublished ones must follow the private vulnerability workflow and use that same severity row only as the **proposed severity** in the private report. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit c78fc3d. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: Polyglot AI <293096396+polyglotAI-bot@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Summary
Follow-up to #1155. Three review findings (Cursor Bugbot on ClickHouse/clickhouse-cpp#613) apply to the same text here; this commit reached the #1155 branch only after the merge.
Medium. Now it is rated as a feature request ("Cosmetic, docs, feature"); only a defect with the impact Performance uses "Workaround exists".The other client repositories get the same text in their open PRs. No library code changes, so there is no changelog entry.
prettier --checkpasses.🤖 Generated with Claude Code
Note
Low Risk
Documentation-only changes to agent triage skills; no runtime library or security-sensitive code paths are modified.
Overview
Updates the shared issue-classification and issue-priority agent skills so triage labels and severity rows stay consistent.
Classification now treats dependency issues (published or unpublished CVE/GHSA) as Security (vulnerability) when the client calls the affected code, narrows authentication to broken/missing methods and credential handling (credential leaks are explicitly vulnerabilities), and adds unpublished dependency findings to the private-report checklist with guidance to contact upstream maintainers privately.
Priority routes “make it faster” requests to Cosmetic, docs, feature while Workaround exists applies only to performance defects; dependency CVEs map to Wrong data or security when vulnerable code is on the execution path, otherwise to a low-priority dependency-update feature request.
Reviewed by Cursor Bugbot for commit 0a64bd3. Bugbot is set up for automated code reviews on this repo. Configure here.