Skip to content

build: inherit shared package fields from [workspace.package], read the MSRV from it (#1352) - #1432

Merged
sdairs merged 1 commit into
claude/release-preflight-lockedfrom
claude/workspace-package-metadata
Nov 16, 2026
Merged

sdairs merged 1 commit into
claude/release-preflight-lockedfrom
claude/workspace-package-metadata

Conversation

@sdairs

@sdairs sdairs commented Nov 13, 2026 •

Copy link
Copy Markdown
Member

Why The MSRV and package metadata were repeated in three manifests and msrv.yml, and release tarballs shipped without a licence.

What Root [workspace.package] holds edition, rust-version (1.94.1), license, repository and homepage; crates inherit them (versions stay per crate, so check-release-versions.py is unaffected). msrv.yml reads rust-version from cargo metadata. Release archives include LICENSE (install.sh, npm and update take the binary by name). The library gets #![forbid(unsafe_code)]; the CLI drops its duplicate serde_json dev-dependency. Cargo.lock unchanged.

QA cargo publish --dry-run -p clickhouse-cloud-api, cargo package --list, maturin sdist metadata, clippy (all configs), all crate tests, scripts/tests. No new tests.

Risks release.yml changed: needs the maintainer exact-SHA override. Dropped per scope: workspace.dependencies, workspace.lints, cargo deny, rust-toolchain.toml. Possible follow-up: README repo-relative links don't resolve on PyPI.

Closes #1352

🤖 Generated with Claude Code


Note

Low Risk
Manifest and CI wiring changes only; release archive layout gains LICENSE without affecting binary extraction; MSRV check behavior is stricter but still validates the same declared version.

Overview
Centralizes edition, MSRV (1.94.1), license, repository, and homepage in root [workspace.package]; all three crates now inherit those fields via *.workspace = true (per-crate version strings stay local).

The MSRV workflow no longer hardcodes a toolchain version—it parses the declared rust_version from cargo metadata, errors if the workspace isn't unified, and installs that toolchain for cargo check. AGENTS.md points maintainers at the workspace root for MSRV bumps.

Release tarballs now include LICENSE beside the binary (install paths still pick up only clickhousectl by name). clickhouse-cloud-api adds #![forbid(unsafe_code)]; clickhousectl drops a redundant serde_json dev-dependency.

Reviewed by Cursor Bugbot for commit fa5f856. Bugbot is set up for automated code reviews on this repo. Configure here.

…he MSRV from it (#1352)

Edition, rust-version, license, repository and homepage live once in the
root manifest; msrv.yml reads rust-version from cargo metadata. Release
tarballs carry LICENSE, the library forbids unsafe code, and the CLI's
duplicate serde_json dev-dependency is gone.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sdairs
sdairs requested a review from iskakaushik as a code owner November 13, 2026 03:38
@sdairs sdairs added this to the v0.6.0 milestone Nov 13, 2026
@sdairs
sdairs added this pull request to stack #1285 November 13, 2026 03:40

@iskakaushik iskakaushik left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdairs
sdairs merged commit e1ae7d7 into main Nov 16, 2026
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Workspace manifests: shared package, dependency and lint tables, a pinned toolchain and a licence check

2 participants