Repository navigation
build: inherit shared package fields from [workspace.package], read the MSRV from it (#1352) - #1432
Merged
sdairs merged 1 commit intoNov 16, 2026
Conversation
…he MSRV from it (#1352) Edition, rust-version, license, repository and homepage live once in the root manifest; msrv.yml reads rust-version from cargo metadata. Release tarballs carry LICENSE, the library forbids unsafe code, and the CLI's duplicate serde_json dev-dependency is gone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
14 of 100 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why The MSRV and package metadata were repeated in three manifests and
msrv.yml, and release tarballs shipped without a licence.What Root
[workspace.package]holds edition, rust-version (1.94.1), license, repository and homepage; crates inherit them (versions stay per crate, socheck-release-versions.pyis unaffected).msrv.ymlreads rust-version fromcargo metadata. Release archives includeLICENSE(install.sh, npm andupdatetake the binary by name). The library gets#![forbid(unsafe_code)]; the CLI drops its duplicateserde_jsondev-dependency. Cargo.lock unchanged.QA
cargo publish --dry-run -p clickhouse-cloud-api,cargo package --list,maturin sdistmetadata, clippy (all configs), all crate tests,scripts/tests. No new tests.Risks
release.ymlchanged: needs the maintainer exact-SHA override. Dropped per scope: workspace.dependencies, workspace.lints, cargo deny, rust-toolchain.toml. Possible follow-up: README repo-relative links don't resolve on PyPI.Closes #1352
🤖 Generated with Claude Code
Note
Low Risk
Manifest and CI wiring changes only; release archive layout gains LICENSE without affecting binary extraction; MSRV check behavior is stricter but still validates the same declared version.
Overview
Centralizes edition, MSRV (
1.94.1), license, repository, and homepage in root[workspace.package]; all three crates now inherit those fields via*.workspace = true(per-crate version strings stay local).The MSRV workflow no longer hardcodes a toolchain version—it parses the declared
rust_versionfromcargo metadata, errors if the workspace isn't unified, and installs that toolchain forcargo check. AGENTS.md points maintainers at the workspace root for MSRV bumps.Release tarballs now include LICENSE beside the binary (install paths still pick up only
clickhousectlby name).clickhouse-cloud-apiadds#![forbid(unsafe_code)];clickhousectldrops a redundantserde_jsondev-dependency.Reviewed by Cursor Bugbot for commit fa5f856. Bugbot is set up for automated code reviews on this repo. Configure here.