Skip to content

fix(ci): bump rustix for RUSTSEC-2026-0486 and keep --version out of the closed-stdout test - #1441

Closed
balanza wants to merge 3 commits into
mainfrom
fix/ci-rustix-and-version-notice
Closed

balanza wants to merge 3 commits into
mainfrom
fix/ci-rustix-and-version-notice

Conversation

@balanza

@balanza balanza commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes 1440

Two failures that hit every PR right now (seen on #1439), neither caused by the PR's own changes:

  1. cargo audit: cargo update -p rustix (1.1.5 → 1.1.6, lockfile only). rustix is reached through crossterm, tempfile and tar's xattr.
  2. local_stdout_test: --version always checks for a newer release online, which CHCTL_UPDATE_CHECK_TIMEOUT_MS does not turn off. Since v0.5.1 was published, the 0.5.0 build prints an update notice on stderr, so the empty-stderr assertion fails. The fix drops --version from that test. Local output and --help still cover the closed-stdout behaviour, and the production code is unchanged.
  3. Install Test (macos-14): GitHub no longer provisions the macos-14 runner, so the job fails at once. The fix drops it from the install matrix; macos-15 still covers macOS on arm64.

Checks: fmt, both clippy configurations and cargo audit --deny warnings are clean, and local_stdout_test passes.


Note

Low Risk
Lockfile security bump and test/CI matrix tweaks only; no production behavior changes.

Overview
Addresses failing cargo audit and local_stdout_test by updating the lockfile and tightening the hermetic CLI test, and narrows install CI to supported runners.

rustix is bumped 1.1.5 → 1.1.6 in Cargo.lock (RUSTSEC-2026-0486), with related dependency edges shifting to windows-sys 0.52.0. The closed-stdout integration test no longer exercises --version—it can emit an update notice on stderr because the online update check isn’t fully disabled—while local list and --help still validate quiet behavior.

Install workflow matrix drops macos-14, leaving ubuntu-22.04, ubuntu-24.04, and macos-15.

Reviewed by Cursor Bugbot for commit f4bb93a. Bugbot is set up for automated code reviews on this repo. Configure here.

rustix 1.1.5 marks unwritten bytes as initialized when an xattr function
gets a zero-length buffer. It is reached through crossterm, tempfile and
tar's xattr, and cargo audit --deny warnings fails on the advisory.
--version always checks for a newer release online, unlike the background
check that CHCTL_UPDATE_CHECK_TIMEOUT_MS turns off. Since v0.5.1 was
published, main (0.5.0) prints an update notice on stderr and the
assertion that stderr stays empty fails on every PR. The test is about CLI
output under a closed reader, which local output and --help still cover.
@balanza balanza added the run-cloud-integration Run live Cloud integration tests for this PR head label Nov 13, 2026
@balanza
balanza temporarily deployed to cloud-integration November 13, 2026 06:37 — with GitHub Actions Inactive
GitHub no longer provisions macos-14 runners: the job fails at once with
"The configuration 'macos-14-arm64-us-default' is not supported".
macos-15 still covers the macOS arm64 install.
@sdairs

sdairs commented Nov 13, 2026

Copy link
Copy Markdown
Member

Thanks; already fixed in another PR pending merge. Will close this as duplicate.

@sdairs sdairs closed this Nov 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-cloud-integration Run live Cloud integration tests for this PR head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants