Repository navigation
build(cli): package only crate sources in clickhousectl and classify ClickPipes live-test paths (#1442) - #1448
Merged
sdairs merged 1 commit intoNov 16, 2026
Conversation
…ClickPipes live-test paths (#1442) Restrict the published clickhousectl crate to src/** and LICENSE (Cargo still adds the root README as README.md). The live tests include the API library's harness through #[path] outside the crate, so shipping tests/ broke cargo test --no-run and clippy --all-targets on the unpacked crate. Test CLI now checks the cargo package --list contents. Map the CLI sources that live_clickpipe_postgres_cdc_test drives through `cloud clickpipe create postgres` (create.rs, destination.rs, table_mapping.rs, sources/mod.rs, sources/postgres.rs) to the clickpipes suite, matching services/query.rs and query_key.rs for the service suite. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
live_clickpipe_postgres_cdc_test.rsandlive_service_query_bind_test.rslive incrates/clickhousectl/tests/(clickhouse-cloud-api carries tests that do not belong to it: CLI-driving live tests and AWS E2E dev-dependencies #1347) and reach into../../clickhouse-cloud-api/tests/common/mod.rsvia#[path]. Without anincludefilter incrates/clickhousectl/Cargo.toml,cargo publish -p clickhousectlbundlestests/, breakingcargo test --no-runandclippy --all-targetson the unpacked.crate.scripts/classify-cloud-integration.pymappedservices/query*.rstoserviceforlive_service_query_bind_test, but left the CLI files driven bylive_clickpipe_postgres_cdc_test(cloud clickpipe create postgres) unmapped.What:
include = ["src/**", "LICENSE"]tocrates/clickhousectl/Cargo.toml(Cargo still bundlesreadme = "../../README.md"asREADME.md) and add acargo package -p clickhousectl --list --lockedcheck to.github/workflows/test-cli.yml.src/cloud/clickpipes/{create.rs,destination.rs,table_mapping.rs,sources/mod.rs,sources/postgres.rs}tofrozenset({"clickpipes"})inscripts/classify-cloud-integration.pywith unit tests.QA:
cargo package -p clickhousectl --list --lockedandpython3 -m unittest discover -s scripts/tests -p 'test_*.py'.Risks: Low; packaging and CI classification only.
Closes #1442
Note
Low Risk
Changes affect crate packaging manifests, CI checks, and live-suite selection metadata only—no runtime CLI or API behavior.
Overview
Restricts the published
clickhousectlcrate tosrc/**andLICENSE(README still comes from the manifest) socargo publishno longer bundlestests/, which would break downstream builds because live suites pull the API harness via#[path]outside the crate.Test CLI workflow gains a
cargo package --listgate that asserts required files are present and rejects anything outside an allowlist (src/, manifest metadata, LICENSE, README).Cloud integration classification now maps the CLI
cloud clickpipe create postgrescode paths (clickpipes/{create,destination,table_mapping,sources/*}) to theclickpipeslive suite, with unit tests and a short note indocs/development.mdtying those sources to their live tests.Reviewed by Cursor Bugbot for commit e610674. Bugbot is set up for automated code reviews on this repo. Configure here.