Repository navigation
Conversation
sdairs
temporarily deployed
to
cloud-integration
November 17, 2026 14:19 — with
GitHub Actions
Inactive
chrono is unmaintained (RUSTSEC-2026-0543). Library timestamp fields are now jiff::Timestamp, the analyzer matches that type, and the CLI parses and formats through two shared helpers that keep RFC 3339 strictness and the previous fraction-digit formatting. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
sdairs
force-pushed
the
deps/1474-jiff-api
branch
from
November 17, 2026 18:11
0848d79 to
7ca24a3
Compare
sdairs
changed the base branch from
main
to
deps/1185-restore-credentials-login
November 17, 2026 18:11
sdairs
temporarily deployed
to
cloud-integration
November 17, 2026 18:14 — with
GitHub Actions
Inactive
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1474
Why
chronois unmaintained (RUSTSEC-2026-0543), socargo audit --deny warningsfails onmainand on every lockfile PR.What
jiff::Timestampinstead ofchrono::DateTime<chrono::Utc>. Changelog entry with the caller migration.Timestampas a string scalar; the chrono type names are gone.cloud/shared.rsgainsparse_rfc3339(checks the RFC 3339 shape before jiff, which also reads wider ISO 8601 forms) andformat_rfc3339(0, 3, 6 or 9 fraction digits, as before).chronois out ofCargo.lock; jiff is built without its time zone database.One PR, not the two the issue planned: the type change breaks the CLI build, so the library cannot land alone.
Behaviour changes
+00:00(activity, API key and invitation expiry, Postgres created and earliest restore) now printZ..5Z, was.500Z). Whole seconds are unchanged. Checked live for API key expiry:key createandkey updateaccept 1, 2, 4 and 9 fraction digits, and the API drops the fraction as it does for main's.500Z. Postgres restore, BYOC and Pub/Sub timestamps were not checked live.QA
cargo fmt; clippy for the CLI (default and--no-default-features), both library crates, and--workspace --all-features;cargo testfor all three crates plus--features deprecated-fields;cargo audit --deny warningspasses.local_structured_errors_testfailed once under the full parallel run and passed on three reruns.Needs the
run-cloud-integrationlabel.🤖 Generated with Claude Code
Note
Medium Risk
Breaking public API types for all timestamp fields plus subtle wire/display formatting differences; large surface area but motivated by a security advisory and covered by changelog migration notes.
Overview
Removes the unmaintained
chronodependency (RUSTSEC-2026-0543) and standardizes onjifffor timestamps acrossclickhouse-cloud-api,clickhousectl, andclickhouse-openapi-analyzer.Library (breaking): every API model timestamp field and aliases like
PgCreatedAtPropertynow usejiff::Timestampinstead ofchrono::DateTime<chrono::Utc>.Cargo.tomlandCHANGELOG.mddocument caller migration (parse,to_string(),as_second()). On the wire, RFC 3339 UTC is unchanged, but serialized fractions use the fewest digits (e.g..5Zvs chrono’s padded.500Z).CLI:
chronois dropped fromclickhousectl; call sites usejiff.cloud/shared.rsaddsparse_rfc3339(stricter RFC 3339 shape than jiff alone) andformat_rfc3339for display and API flags. Activity date defaults, OAuth token expiry, Postgres windows, Pub/Sub seek times, BYOC access windows, and human tables now go through these helpers (UTC suffixes showZwhere some tables used+00:00).Analyzer: response schema checks treat
Timestampas the string scalar instead ofDateTime/ chrono types.Tests and integration code are updated to parse and compare
jiff::Timestampvalues consistently.Reviewed by Cursor Bugbot for commit 7ca24a3. Bugbot is set up for automated code reviews on this repo. Configure here.