Skip to content

fix(api): Postgres standby count; graduate Postgres operations from Beta (#1466) - #1477

Open
sdairs wants to merge 1 commit into
claude/drift-1466-api-servicesfrom
claude/drift-1466-api-postgres
Open

sdairs wants to merge 1 commit into
claude/drift-1466-api-servicesfrom
claude/drift-1466-api-postgres

Conversation

@sdairs

@sdairs sdairs commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

Refs #1466. API PR 2 of 3, stacked on the services PR. CLI exposure follows in #1471.

  • New PgStandbyCount integer enum (0/1/2, Unknown(i64) catch-all).
  • standby_count: Option<PgStandbyCount> on PostgresService, PostgresServiceListItem, PostgresServicePostRequest and PostgresServicePatchRequest. It is required on the orphan BasePostgresService, as the spec says.
  • 19 Postgres operations leave BETA_OPERATIONS (regenerated); DEPRECATED_FIELDS unchanged.
  • Model, wiremock and facade tests, plus a non-blocking live step.
  • CLI: compile-only, sends standby_count: None (pinned).

spec_coverage_test is expected to fail here; its failures list only the ClickStack drift.

🤖 Generated with Claude Code


Note

Medium Risk
New required field on BasePostgresService and struct-literal updates can break callers; standby count ties to HA configuration and most Postgres APIs are no longer marked Beta.

Overview
Adds PgStandbyCount (0/1/2 plus Unknown) and optional standby_count on Postgres service/list/create/PATCH models, with a required field on BasePostgresService. Omitted values follow HA-type defaults on the API; wire JSON uses integer standbyCount, omitted when unset on requests.

Graduates 19 Postgres client operations from Beta by trimming meta::BETA_OPERATIONS (create remains beta). Updates changelog, model/facade tests, wiremock client coverage, and a live integration check for default standby count when haType is none.

clickhousectl only sets standby_count: None on create/update until CLI exposure lands in a follow-up.

Reviewed by Cursor Bugbot for commit 3f369c8. Bugbot is set up for automated code reviews on this repo. Configure here.

… from Beta

- New `PgStandbyCount` integer enum (0, 1, 2, Unknown(i64)) for the
  `pgStandbyCount` schema.
- `standby_count` on PostgresService, PostgresServiceListItem,
  PostgresServicePostRequest and PostgresServicePatchRequest (optional) and
  on the orphan BasePostgresService (required, as the spec resolves it).
- Regenerate BETA_OPERATIONS: 19 Postgres operations are no longer Beta.
- CLI: `cloud postgres create/update` send no standbyCount (pinned by the
  existing builder tests); live test literals gain the new field.

Refs #1466

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant