Repository navigation
Conversation
- `cloud service create --deletion-protection` and `cloud service update --deletion-protection true|false` send the new `deletionProtection` field; update prints the resulting setting. - `cloud service list` gains a Deletion protection column; `get` already renders the field. - `cloud service delete` refuses a protected service with the new `deletion_protected` error code, whose `command` is the update that turns protection off. `--force` checks the service it already reads and refuses before stopping it; a 409 from the DELETE is diagnosed with a read so a protected service is no longer told to stop or use --force. - Help: permission notes for create/update, the delete gotcha, and EC JWKS keys (ES256/384/512) on ClickHouse 26.8+ for jwt-provider. - Docs: cloud-service guide section and automation error-code reference. Fixes #1470 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
sdairs
force-pushed
the
claude/drift-1466-cli-services
branch
from
November 17, 2026 16:45
1de8f41 to
b2701f8
Compare
sdairs
changed the base branch from
claude/drift-1466-api-services
to
claude/drift-1466-api-clickstack
November 17, 2026 16:45
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1470. CLI PR for the services part of #1466, stacked on #1476.
cloud service create --deletion-protection(a switch) andcloud service update --deletion-protection true|false.listhas a Deletion protection column;getalready shows the field.cloud service deleterefuses a protected service with the new JSON error codedeletion_protected(exit 1). The error'scommandfield holds theupdate --deletion-protection falsecommand to run.--force, the service is checked before it is stopped, so a protected service is never stopped.--force, a 409 from the DELETE triggers a GET to tell deletion protection apart from other conflicts.yes_nohelper moves tocloud/output.rsso services can share it.--forcedelete with no stop, and DELETE 409 → GET →deletion_protected.🤖 Generated with Claude Code
Note
Medium Risk
Changes irreversible delete paths and structured error codes; mis-handling could stop or delete the wrong service, though protection is meant to reduce accidental deletion risk.
Overview
Adds deletion protection to ClickHouse Cloud services in
clickhousectl:cloud service create --deletion-protectionandcloud service update --deletion-protection true|false, with a Deletion protection column onservice listand updated help/permissions text.Delete behavior is stricter: protected services are refused with JSON code
deletion_protectedand acommandpointing atservice update … --deletion-protection false. With--force, protection is checked before any stop attempt; without--force, DELETE 409 is disambiguated via a follow-up GET.Also moves shared
yes_noformatting tocloud/output.rs, documents EC JWT keys (ES256/384/512) on ClickHouse 26.8+ in help/docs, and adds parsing, builder, unit, and wiremock tests plus guide/automation reference updates.Reviewed by Cursor Bugbot for commit b2701f8. Bugbot is set up for automated code reviews on this repo. Configure here.