Repository navigation
Conversation
Adds the four beta `postgresPrivateEndpoint*` operations as
`postgres_private_endpoint_{get,post,patch,delete}`, their models
(`PostgresPrivateEndpoint`, `PostgresPrivateEndpointPort`, the post and
patch requests, and the split `PostgresPrivateEndpointVpcEndpoint` /
`PostgresPrivateEndpointVpcEndpointResponse` pair with a `TryFrom`
write-back), the operation descriptors and the Beta list entries.
`PostgresPrivateEndpointPostRequest` is listed as an optional request
schema: its only field needs a feature most organizations lack.
The live Postgres suite gains a private endpoint phase, gated on AWS and
`CLICKHOUSE_CLOUD_POSTGRES_PRIVATE_ENDPOINT`.
Fixes #1482
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1482. API PR 2 of 2, stacked on the roles API PR. CLI exposure follows in #1485.
postgres_private_endpoint_get,_post,_patchand_delete. Operation descriptors are regenerated, and the four are added toBETA_OPERATIONS(regenerated;DEPRECATED_FIELDSunchanged).PostgresPrivateEndpointandPostgresPrivateEndpointPort: response only, allOption.PostgresPrivateEndpointPostRequestandPostgresPrivateEndpointPatchRequest: allOption.PostgresPrivateEndpointVpcEndpoint(strictvpc_endpoint_id) andPostgresPrivateEndpointVpcEndpointResponse, withTryFromfor writing a fetched list back. The PATCH replaces each list in full, and the CLI PR (cloud postgres private-endpoint: manage Postgres AWS private endpoints #1485) is the read-modify-write caller.PostgresPrivateEndpointPostRequestjoinsoptional_request_schemas. It has norequired[]and no "Optional" description, so the fallback markssupportedRegionsrequired. But the operation does not require a body, and the field needs cross-region private endpoints, which most organizations do not have. Not yet confirmed against the live API.TryFrom;available, patch empty lists, delete). It runs only on AWS withCLICKHOUSE_CLOUD_POSTGRES_PRIVATE_ENDPOINTset, because the feature is per organization and creation adds 5 to 10 minutes. This is documented indocs/development.md, but the workflow is not wired up.spec_coverage_testpasses from here, and the live drift dry-run reports no #1482 findings.🤖 Generated with Claude Code
Note
Low Risk
Additive API surface with thorough tests; live private-endpoint flows are gated and non-blocking, with no changes to existing Postgres operations.
Overview
Adds beta support for managing AWS private endpoint services on Postgres instances through four new
Clientmethods:postgres_private_endpoint_get,_post,_patch, and_delete. Operation metadata andBETA_OPERATIONSare regenerated accordingly.New request/response models cover endpoint state, ports, supported regions, and approved VPC endpoints. PATCH list fields (
allowed_vpc_endpoints,supported_regions) replace existing values in full; aTryFromon VPC endpoint responses supports read-modify-write.PostgresPrivateEndpointPostRequestis exempted in the OpenAPI analyzer sosupported_regionsstays optional (orgs without cross-region private endpoints can send an empty body).Coverage includes wiremock tests per method, model/facade tests, an opt-in live integration phase (AWS +
CLICKHOUSE_CLOUD_POSTGRES_PRIVATE_ENDPOINT), and changelog/docs updates.Reviewed by Cursor Bugbot for commit 26231a6. Bugbot is set up for automated code reviews on this repo. Configure here.