Repository navigation
Conversation
The API now pages the role list. `cloud org role list` and role name lookups read every page, so the output and lookups stay complete. Fixes #1484 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1484. CLI PR for the roles part of #1482, stacked on the Postgres private endpoint API PR.
CloudClient::list_organization_rolesfollowsnextCursorthroughcollect_cursor_pages. This applies to bothcloud org role listand role name lookups, so both stay complete for organizations with more than 250 roles. A repeated cursor fails, as for other paged lists.role list(JSON order) and forrole get --nameon a role from the second page.🤖 Generated with Claude Code
Note
Low Risk
Read-path pagination fix in the CLI client, aligned with existing org-list behavior; no auth or write-path changes.
Overview
Organization role listing now walks the API’s
nextCursorvia the sharedcollect_cursor_pageshelper instead of returning only the first page. That fixes incomplete output forcloud org role listand fororg role get --name(and other name-based selectors) when a role sits beyond the first page—e.g. orgs with more than 250 roles.A subprocess test mocks two list pages and asserts merged JSON order for
role list, plus successful name lookup for a role on page two.Reviewed by Cursor Bugbot for commit 22eb228. Bugbot is set up for automated code reviews on this repo. Configure here.