Repository navigation
Conversation
Adds `cloud postgres private-endpoint get|create|update|delete` (Beta). `update` reads the endpoint and merges `--add-vpc-endpoint`, `--remove-vpc-endpoint`, `--add-region` and `--remove-region` into the current lists, because the API replaces each list it is sent in full; it sends only the lists that change. Removing something absent warns, as `cloud service update` does. `delete` prints the endpoint it read first, as `cloud postgres delete` does. Fixes #1485 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1485. CLI PR for the Postgres private endpoint part of #1482, stacked on the roles CLI PR.
New
cloud postgres private-endpointgroup (Beta), each command selecting the service by ID or--name:getprints the endpoint.create [--supported-region R]...returns at once. Human output points togetuntilstate=available. No--wait, matchingcloud postgres create.updatewith--add-vpc-endpoint VPCE_ID[=DESCRIPTION],--remove-vpc-endpoint VPCE_ID,--add-region Rand--remove-region R, all repeatable, at least one required.cloud service update(cloud service private-endpoint create accepts arbitrary bogus VPC endpoint IDs #611), removals are not format-checked and a removal that matches nothing is a stderr warning, not a failure. Added IDs are checked againstvpce-plus 17 hex digits at parse time.deletereads the endpoint, deletes it, and prints what it read, ascloud postgres deletedoes.--namelookup.docs/guides/managed-postgres.mdgains a "Connect privately over AWS PrivateLink (Beta)" section.🤖 Generated with Claude Code
Note
Medium Risk
New write paths change private connectivity and VPC approvals; mistaken update/delete can drop access, though merge logic and warnings limit accidental full-list loss.
Overview
Adds
clickhousectl cloud postgres private-endpoint(Beta) with get, create, update, and delete for AWS Postgres PrivateLink endpoint services.Update merges VPC approvals and supported regions client-side (API PATCH replaces whole lists): optional --add/remove-vpc-endpoint and --add/remove-region, validated adds for
vpce-IDs, idempotent removals with stderr warnings. Create supports repeatable --supported-region; delete prints the endpoint read before DELETE. The change wires CloudClient helpers, permission declarations, clap/read-write classification, unit and mock HTTP tests, and a managed Postgres doc section for the PrivateLink workflow.Reviewed by Cursor Bugbot for commit ad30775. Bugbot is set up for automated code reviews on this repo. Configure here.