Repository navigation
Conversation
…pe create Sends `useJsonNativeFormat` only when the flag is given, like the other create-time CDC booleans, since the setting must be enabled for the organization. Fixes #1490 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1490. Stacked on the
useJsonNativeFormatAPI PR.cloud clickpipe create postgresandcreate mysqltake--use-json-native-format <true|false>, following--use-compression/--delete-on-merge. It is omitted unless given, because the setting must be enabled for the organization.updatehas no such flag.docs/reference/clickpipe-configuration.mdlists it with the other create-time choices.🤖 Generated with Claude Code
Note
Low Risk
CLI-only create-time flag wiring and tests; no update path or auth/data-path changes.
Overview
Adds
--use-json-native-format true|falsetoclickpipe create postgresandclickpipe create mysql, matching other create-time CDC booleans. The flag is optional: when omitted,useJsonNativeFormatis not sent on the create request so orgs without the feature are unchanged; when set, it is passed through to pipe settings.Docs document the option as create-only for Postgres/MySQL (ClickHouse 25.3+, org feature), native
JSONvsString, and wrapping/array behavior. Tests cover CLI parsing (maximal/minimal) and request builders for both sources.Reviewed by Cursor Bugbot for commit c8a955f. Bugbot is set up for automated code reviews on this repo. Configure here.