Repository navigation
Resolve every --output the same way: existing directory or trailing slash is a directory, anything else a file - #51
Merged
Merged
Conversation
LocalMessageFile.destination(for:named:) had the right rule since #36 — an existing directory or a trailing slash is a directory, anything else is the filename to write — but it was private to --part. Move it to OutputPath so the IMAP-backed commands can share it, split out namesDirectory for callers that must validate before writing, and test the rule once on the helper instead of per command. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Fetch kept its own existence check plus a pathExtension test, so an extensionless --output like 'invoice' became a directory holding <uid>.eml. Drop the precomputed outputDir and resolve each destination with the shared rule; an explicit filename now also applies to the text-body export instead of being ignored. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Both keyed on pathExtension alone, so an existing directory named exports.v1 or archive.pdf was handed to Data.write as a file, and an extensionless filename silently became a directory. PDF's own variant also treated report.pdf.bak as a directory. The multi-UID filename rejection in pdf survives on top of the shared rule, and the help text now states the rule instead of 'directory or filename'. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 530772b1c0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
A missing ./backup or ./downloads is now a filename, so the examples must say ./backup/ to get the directory they describe. The fetch examples also spelled the option --out, which the parser rejects. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #37.