Repository navigation
CommandFailure: a command's error prints as the command words it - #25
Merged
Merged
Conversation
A bridged ArgumentParser command that fails the way a real tool does (git's `fatal: …`, exit 128) had its text run through ArgumentParser's formatter: `Error: ` in front, and exit 1. An error conforming to the new CommandFailure protocol now has its diagnostic written to stderr as is, and its exit status returned. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In-process commands bridged through
Shell.parsableCommand(_:)couldn't fail the way the tool they port does. SwiftPorts'gitthrows itsCLIErrorwith git's exact words and status. In an embedding shell (iBash on iOS), the bridge handed that to ArgumentParser's formatter, so this:came out where git prints the two lines without
Error:and exits 128. Every failinggitcommand in iBash showedError: error: …and exit 1.Change
CommandFailureprotocol in ShellKit: anErrorwith adiagnostic(written to stderr as is) and anexitStatus.ParsableCommandBridgecatches it before falling back to ArgumentParser's formatter.Commands that don't conform are unchanged. SwiftPorts'
CLIErroradopts the protocol in a follow-up PR.Tests
commandFailurePrintsItsOwnDiagnosticAndStatuschecks that the diagnostic is printed byte for byte and the exit status is 128. It fails without the bridge change. All 67 tests pass, and lint is clean.🤖 Generated with Claude Code