Skip to content

feat: cache valgrind installation from runner - #140

Merged
GuillaumeLagrange merged 5 commits into
mainfrom
cod-1336-cache-setup-environment-step-in-the-github-action
Oct 16, 2025
Merged

feat: cache valgrind installation from runner#140
GuillaumeLagrange merged 5 commits into
mainfrom
cod-1336-cache-setup-environment-step-in-the-github-action

Conversation

@GuillaumeLagrange

Copy link
Copy Markdown
Contributor

No description provided.

@GuillaumeLagrange
GuillaumeLagrange force-pushed the cod-1336-cache-setup-environment-step-in-the-github-action branch 2 times, most recently from 43d0752 to 770558f Compare October 14, 2025 14:33
Comment thread action.yml
Comment thread action.yml
Comment thread action.yml Outdated
Comment thread action.yml Outdated

art049 commented Oct 16, 2025

Copy link
Copy Markdown
Member

Also as discussed, it would be safer to add the kernel version to the cache key (and the restore key) since perf setup depends on the kernel version and a same os version might use multiple kernel versions

@GuillaumeLagrange
GuillaumeLagrange force-pushed the cod-1336-cache-setup-environment-step-in-the-github-action branch from 5970b8d to 1dbaaf7 Compare October 16, 2025 14:23
@GuillaumeLagrange
GuillaumeLagrange force-pushed the cod-1336-cache-setup-environment-step-in-the-github-action branch from 1dbaaf7 to f5284a6 Compare October 16, 2025 15:16
@GuillaumeLagrange
GuillaumeLagrange force-pushed the cod-1336-cache-setup-environment-step-in-the-github-action branch from 66567d4 to bc11677 Compare October 16, 2025 15:29
@GuillaumeLagrange
GuillaumeLagrange merged commit bc11677 into main Oct 16, 2025
13 checks passed
@GuillaumeLagrange
GuillaumeLagrange deleted the cod-1336-cache-setup-environment-step-in-the-github-action branch October 16, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants