Accept both simulation and instrumentation as a mode input - #155
Merged
GuillaumeLagrange merged 3 commits intoNov 19, 2025
Merged
Conversation
adriencaccia
approved these changes
Nov 13, 2025
GuillaumeLagrange
force-pushed
the
cod-1441-accept-simulation-as-a-value-instrumentation-which-is-now
branch
from
November 19, 2025 10:32
3ecd5e4 to
503f65a
Compare
GuillaumeLagrange
force-pushed
the
cod-1441-accept-simulation-as-a-value-instrumentation-which-is-now
branch
from
November 19, 2025 10:37
40f91b4 to
41b649a
Compare
GuillaumeLagrange
deleted the
cod-1441-accept-simulation-as-a-value-instrumentation-which-is-now
branch
November 19, 2025 10:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Question to the reviewer: do we bother auto transforming simulation to instrumentation when runner version is below the runner version where we introduced simulation as a possible value ? IMO no, but up for discussion.
Note: CI will fail until we release the runner