-
Notifications
You must be signed in to change notification settings - Fork 25
feat: add experimental --exclude-allocations setting #425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,6 +25,19 @@ pub struct ExperimentalArgs { | |
| env = "CODSPEED_CYCLE_ESTIMATION" | ||
| )] | ||
| pub cycle_estimation: bool, | ||
|
|
||
| /// Exclude memory allocation time from simulation results. | ||
| /// | ||
| /// Signals the backend to parse and subtract allocator time when interpreting | ||
| /// the run. Runs with different values are not comparable, so the value is part | ||
| /// of the run's measurement configuration. | ||
| #[arg( | ||
| long = "unstable-exclude-allocations", | ||
| default_value_t = false, | ||
| help_heading = "Experimental", | ||
| env = "CODSPEED_UNSTABLE_EXCLUDE_ALLOCATIONS" | ||
| )] | ||
| pub exclude_allocations: bool, | ||
|
Comment on lines
+29
to
+40
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We have three different schemes for the three exeprimental args one encodes one encodes one does not do any of it can we align these? I suggest keeping |
||
| } | ||
|
|
||
| impl ExperimentalArgs { | ||
|
|
@@ -37,6 +50,9 @@ impl ExperimentalArgs { | |
| if self.cycle_estimation { | ||
| flags.push("--cycle-estimation"); | ||
| } | ||
| if self.exclude_allocations { | ||
| flags.push("--unstable-exclude-allocations"); | ||
| } | ||
| flags | ||
| } | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Too much information IMO here