Skip to content

Fix EF Core transaction execution for user deletion and refresh tokens - #117

Merged
mckaragoz merged 1 commit into
CodeBeamOrg:devfrom
mckaragoz:UserDeleteFix
Oct 27, 2026
Merged

mckaragoz merged 1 commit into
CodeBeamOrg:devfrom
mckaragoz:UserDeleteFix

Conversation

@mckaragoz

Copy link
Copy Markdown
Contributor

Summary

Fixes #116
Partially addresses #104

Fixes EF Core transaction execution issues affecting user deletion and refresh token persistence.

Changes

  • Fix session revocation execution during DeleteUserAsync and DeleteMeAsync.
  • Update EfCoreRefreshTokenStore to participate in existing transactions without creating nested transactions.
  • Preserve transaction ownership and rollback behavior.
  • Add regression tests for user deletion, session revocation, refresh token persistence, and transaction rollback.

Notes

No public API changes or breaking changes.

@codecov-commenter

codecov-commenter commented Oct 27, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.25352% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.82%. Comparing base (d507a94) to head (d0d8566).

Files with missing lines Patch % Lines
...Users.Reference/Services/UserApplicationService.cs 90.51% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #117      +/-   ##
==========================================
+ Coverage   86.80%   86.82%   +0.02%     
==========================================
  Files         681      681              
  Lines       18818    18878      +60     
  Branches     2287     2281       -6     
==========================================
+ Hits        16335    16391      +56     
- Misses       1738     1744       +6     
+ Partials      745      743       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mckaragoz
mckaragoz merged commit 4d6bb39 into CodeBeamOrg:dev Oct 27, 2026
3 checks passed
@mckaragoz
mckaragoz deleted the UserDeleteFix branch October 31, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: User deletion fails when revoking sessions outside session store execution scope

2 participants