Skip to content

Fix identifier uniqueness consistency across persistence stores - #127

Merged
mckaragoz merged 1 commit into
CodeBeamOrg:devfrom
mckaragoz:SoftDeletedIdentifierExistsFix
Oct 31, 2026
Merged

mckaragoz merged 1 commit into
CodeBeamOrg:devfrom
mckaragoz:SoftDeletedIdentifierExistsFix

Conversation

@mckaragoz

@mckaragoz mckaragoz commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Closes #120

Align identifier uniqueness behavior across InMemory and EF Core persistence implementations.

Changes

  • Fix existence checks to include soft-deleted identifiers whose values remain reserved.
  • Temporarily mark None and WithinUser as obsolete and reject unsupported configurations.
  • Add regression tests for duplicate identifiers, soft-delete reservations, and uniqueness enforcement.

Notes

None and WithinUser uniqueness scopes are deferred to the planned v0.5.0 multi-tenant expansion.

Compatibility: Configurations using these scopes will need to switch to Tenant.

@codecov

codecov Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.75%. Comparing base (f7a6a55) to head (14c4026).
⚠️ Report is 2 commits behind head on dev.

Additional details and impacted files
@@             Coverage Diff             @@
##              dev     #127       +/-   ##
===========================================
+ Coverage   72.96%   86.75%   +13.78%     
===========================================
  Files         775      681       -94     
  Lines       23766    18900     -4866     
  Branches     3045     2291      -754     
===========================================
- Hits        17341    16396      -945     
+ Misses       5620     1760     -3860     
+ Partials      805      744       -61     
Flag Coverage Δ
framework 86.75% <100.00%> (+<0.01%) ⬆️
identitylab ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mckaragoz
mckaragoz merged commit c2b2576 into CodeBeamOrg:dev Oct 31, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Identifier availability ignores soft-deleted identifiers reserved by uniqueness constraints

1 participant