Nothing listens on another seat's behalf, so the minter subscribes to nothing (comms-g5zh.7) - #213
Merged
Merged
Conversation
… nothing (comms-g5zh.7) The minter subscribed to every public stream so it could receive on behalf of a seat that had not yet minted, kept current by a boot-time reconciler. With the events queue and the channel subscriptions both registered under the seat's own principal, no seat receives through another, and that layer has nothing left to do. The minter keeps the jobs that are its own: minting bots, and the directory and history reads that need no principal. Deletes `minter-reconciler.ts`, its `reconcileMinterSubscriptions` wiring in the Zulip adapter, the boot call in the plugin's `main`, and the covering tests — the capability they cover is gone with it. The prose that described the arrangement (`tools.ts`, `agent-experience.md`, the client README, the adapter's per-event filter) now describes what the code does. A seat that never mints costs the realm nothing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The minter subscribed to every public stream so it could receive on behalf of a seat that had not yet minted, kept current by a boot-time reconciler. With the events queue (#209) and the channel subscriptions (#211, #212) both registered under the seat's own principal, no seat receives through another — and that layer has nothing left to do.
The minter keeps the jobs that are its own: minting bots, and the directory and history reads that need no principal.
Removed
packages/zulip/minter-reconciler.tsand its tests.reconcileMinterSubscriptionsfrom the Zulip adapter's shape, its wiring, and its response schema.main, and its logging.server.test.tstests covering the deleted capability.lazy mode does NOT mint at boot when COMMY_SUBSCRIBE is unsetalready asserts the property that matters — a seat that never mints subscribes to nothing.Corrected
Prose that described the retired arrangement:
tools.tsstill claimed subscribe registered the minter for post-boot streams (it has gone out on the seat's own credential since #211), the adapter's per-event filter named the minter's subscription list, and the client README's boot diagram opened with the reconcile step.docs/agent-experience.mdnow reads as the worked example predicted: topic narrows and the event-queue handle are what remain client-side, both filtering the agent's own queue.Pure subtraction — no new capability, no shims. Subscription reconstruction (comms-70g4) is downstream of this, not part of it.
https://claude.ai/code/session_01P67vRP5hs9Yvo16vkWru4g