fast-uri's override already admits the fix, so only the lock pin moves - #220
Draft
GraemeF wants to merge 1 commit into
Draft
fast-uri's override already admits the fix, so only the lock pin moves#220GraemeF wants to merge 1 commit into
GraemeF wants to merge 1 commit into
Conversation
Clears five HIGH advisories by moving `fast-uri` 4.1.1 -> 4.1.3 in `bun.lock`. One line, no manifest change. - GHSA-7p8r-x3mc-p8w7 — fixed in 4.1.2 - GHSA-5jgf-p345-68v8 — host confusion via skipped IDN canonicalisation - GHSA-f65p-4m7j-42xc — SSRF via malformed authority - GHSA-fph4-wmhf-6fwf — SSRF via repeated components - GHSA-jqff-g426-hqxp — host confusion via percent-encoded scheme The last four were published 2026-09-02 and are all fixed in 4.1.3, so the same one-line move that this branch already carried for the first one clears all five once the pin lands on 4.1.3 rather than 4.1.2. ## Why it's a lockfile-only change `fast-uri` is transitive. It arrives through `ajv`, which declares `fast-uri: ^3.0.1`, and `package.json`'s `overrides` block already raises that to `^4.1.1`. 4.1.3 satisfies the override, so the lock pin was the only thing holding the tree on the vulnerable version. The override also collapses `ajv` onto the single 4.x resolution, so `bun.lock` holds exactly one `fast-uri` entry and one pin move covers the tree — there is no 3.x copy left behind, and the 3.x line is vulnerable to all five. ## Why the entry is edited rather than re-resolved `bun update fast-uri` does not fix this. It reports `installed fast-uri@4.1.1`, leaves the lock entry unmoved, and adds `fast-uri` to the root `package.json` as a direct dependency pinned exactly — because `bunfig.toml` sets `exact = true`. The manifest changes and the vulnerable copy stays. PR #216 recorded the same behaviour for `ip-address`. Editing the single lock line keeps the diff to what the advisories require. `bun install --frozen-lockfile` accepts the result against a wiped `node_modules` — which is also what verifies the hand-written integrity hash, since bun checks the tarball against it — and the only copy in the tree is `node_modules/.bun/fast-uri@4.1.3`. ## Supply-chain gate `bunfig.toml` sets `minimumReleaseAge = 604800`. 4.1.3 published 2026-08-23, so it clears the seven-day window by 11 days. The gate was not lowered or bypassed. `fast-uri` 4.1.4 published 2026-09-02 and is inside the window until 2026-09-09. The override's caret admits it, so the gate is what holds this resolution at 4.1.3. No advisory here names 4.1.4. ## Not in this PR - **GHSA-v2hh-gcrm-f6hx** is fixed in `fast-uri` 4.1.1 and `main` is already there. No work. - **A release.** commy carries 27 commits unreleased since `commy-v0.22.0`, tracked as `comms-ngz0`. This merge fixes `main`, not the published npm bundle. Raised by nixos-config from osv-scanner findings; tracked as `comms-k9f9`.
GraemeF
force-pushed
the
deps/fast-uri-comms-k9f9
branch
from
September 3, 2026 06:33
a0b8fcc to
7c32152
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears five HIGH advisories by moving
fast-uri4.1.1 -> 4.1.3 inbun.lock. One line, no manifest change.The last four were published 2026-09-02 and are all fixed in 4.1.3, so
the same one-line move that this branch already carried for the first
one clears all five once the pin lands on 4.1.3 rather than 4.1.2.
Why it's a lockfile-only change
fast-uriis transitive. It arrives throughajv, which declaresfast-uri: ^3.0.1, andpackage.json'soverridesblock alreadyraises that to
^4.1.1. 4.1.3 satisfies the override, so the lock pinwas the only thing holding the tree on the vulnerable version. The
override also collapses
ajvonto the single 4.x resolution, sobun.lockholds exactly onefast-urientry and one pin move coversthe tree — there is no 3.x copy left behind, and the 3.x line is
vulnerable to all five.
Why the entry is edited rather than re-resolved
bun update fast-uridoes not fix this. It reportsinstalled fast-uri@4.1.1, leaves the lock entry unmoved, and addsfast-uritothe root
package.jsonas a direct dependency pinned exactly — becausebunfig.tomlsetsexact = true. The manifest changes and thevulnerable copy stays. PR #216 recorded the same behaviour for
ip-address.Editing the single lock line keeps the diff to what the advisories
require.
bun install --frozen-lockfileaccepts the result against awiped
node_modules— which is also what verifies the hand-writtenintegrity hash, since bun checks the tarball against it — and the only
copy in the tree is
node_modules/.bun/fast-uri@4.1.3.Supply-chain gate
bunfig.tomlsetsminimumReleaseAge = 604800. 4.1.3 published2026-08-23, so it clears the seven-day window by 11 days. The gate was
not lowered or bypassed.
fast-uri4.1.4 published 2026-09-02 and is inside the window until2026-09-09. The override's caret admits it, so the gate is what holds
this resolution at 4.1.3. No advisory here names 4.1.4.
Not in this PR
fast-uri4.1.1 andmainisalready there. No work.
commy-v0.22.0, tracked ascomms-ngz0. This merge fixesmain, notthe published npm bundle.
Raised by nixos-config from osv-scanner findings; tracked as
comms-k9f9.