Skip to content

Upload page navigates to /documents/new-doc-id when the response has no id, and uses a finance example as the title placeholder #1512

Closed

Description

@mftee

After a successful upload the page does const data = await response.json().catch(() => ({ id: 'new-doc-id' })) and docId = data.id || data.documentId || 'new-doc-id', then routes to /documents/new-doc-id, a page that cannot exist. The title input's placeholder is 'e.g. Q2 Financial Report', which is unrelated to land documents.

Where

  • frontend/app/[locale]/(protected)/documents/upload/page.tsx

Suggested fix
Treat a missing id as an error (show a message and stay on the page), validate the response with a zod schema, and use land-document placeholder text from the i18n messages.

Acceptance criteria

  • No placeholder id is ever navigated to
  • Response validated by a schema
  • Placeholder text is domain-appropriate and translated

Activity

  1. NteinPrecious commented on Oct 17, 2026

    @NteinPrecious
    Contributor

    @NteinPrecious has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hi, I'd like to take this on.

    I've worked on blockchain and Web3 projects, including Stellar and Soroban smart contracts, alongside traditional full-stack web development. I'm comfortable moving between frontend, backend, and on-chain work.

    I understand what's being asked here and I'm confident I can implement this correctly and efficiently.

    Looking forward to contributing — please assign this issue to me.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @NteinPrecious to this issue.

  2. OffixialSydney commented on Oct 17, 2026

    @OffixialSydney

    @OffixialSydney has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hello Maintainer, I’ve gone through the issue and its acceptance criteria carefully. I understand what needs to be implemented and am confident I can deliver a solution that aligns with the expected design.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @OffixialSydney to this issue.

  3. drips-wave commented on Oct 17, 2026

    @drips-wave

    Congratulations, @NteinPrecious! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on October 22, 2026.

    🧑‍💻 @NteinPrecious: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

    Warning

    When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

    🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

    🌊 Happy Wave 🌊

  4. grantfox-oss commented on Oct 17, 2026

    @grantfox-oss

    🎉 This issue has been marked as completed on GrantFox!

    @NteinPrecious's PR #1555 was approved and merged by @mftee.

    🏆 @NteinPrecious: You earned 40 FoxPoints for this contribution! Your current tier: Builder (2,548 total points). Track your full progress on GrantFox.

    👏 Great work, @NteinPrecious! Keep contributing to CodeGirlsInc.

  5. added a commit that references this issue on Oct 17, 2026
  6. drips-wave commented on Oct 17, 2026

    @drips-wave

    This issue has been completed by @NteinPrecious as part of the Stellar Wave Program's 10th Wave 🥳

    😎 @NteinPrecious: You earned 200 Points for completing this issue! Once the Wave's rewards are finalized, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

    🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions