Adding TD2350D printer

[alaindeseine]

Hi @CodeMinion

Just receive the new TD2350 printer from Brother!

Are you ok to add it to another_brother with some custom paper?

I can test it during one month.

Regards
Alain

[alaindeseine]

Hi @CodeMinion

Brother tell me that the new TD2350 printer is supported since the 4.9.1 version of the SDK. Last version of the SDK is 4.12.

I have see that the current version of SDK Brother supported by another_brother is 4.6.

Tell me if i can help.

Regards,

Alain Deseine

[CodeMinion]

Hi @alaindeseine ,

Thanks for reaching out about this and apologies for such a delayed reply.

Depending on how Brother added the support to the new printer it may either be a quick add or take quite a bit of effort. Even though we currently use 4.9 we are still using the legacy implementation inside that library because their new way to configure printing in v4+ is a bit different than in v3.5+.

We would first need to see how they ended up supporting it, so if you have the ARR handy for 4.12 and can share it we can go ahead and place it in the artifact server to make it available so we or others can explore this in the community.

If it proves to be the case that it can still be supported using the path we currently have then the support for this new printer will be quite simple to add without much effort along with the new papers.

Once more apologies for the delayed response and thanks again for reaching out,

[PrimaelQuemerais]

Hi @CodeMinion @alaindeseine
I've been working on adding support for the TD2350D but everything I've tried so far ends up in a ERROR_WRONG_CUSTOM_INFO

I was waiting to get a working version before sending a PR but I think we do need to update the SDK.

Here is the latest version of the library (v4.12) : https://drive.google.com/file/d/1sjZo_yEPwc15VfEdt4bojD4n-7e4Rl-j/view?usp=share_link

Once available I can keep working on the implementation ;)

[CodeMinion]

Hi @PrimaelQuemerais ,

Thanks for the AAR. The AAR is now available and can be retrieved from Android using: com.brother.sdk:printer:4.12.0@aar in the Gradle build file.

Thanks again for your support with this,

[PrimaelQuemerais]

Hello @CodeMinion I hope you're doing good.
I finally had some time to look into the new printer implementation again. From what I see we should be able support it without changing the entire implementation to v4. However, they introduced a new system where the model name is no longer sufficient as the TD2350D exists in multiple versions with difference DPIs (TD2350D_203, TD2350D_300, TD_2350DF_203, ...).
The documentation includes a new method for this matter : setPrinterModelFromStatus
Moreover this message now appears under the modelName property :

For TD-23XX series, modelName does not indentify the model. For example, if modelName is "TD-2350D".
The model is either TD-2350D_203 or TD-2350D_300. Use setPrinterModelFromStatus to set the PrinterModel.

I'm unsure how to concile this system with your current implementation. Would you have time to have a look at it with me?

[PrimaelQuemerais]

@alaindeseine @balanpaul
If you can't wait for the PR to be merged feel free to use my fork.

  another_brother:
    git:
      url: https://github.com/PrimaelQuemerais/another_brother.git

[balanpaul]

Thanks @PrimaelQuemerais ,

I’m still waiting for the printer to arrive. Once it does, I’ll test it and update you.

[alaindeseine]

@PrimaelQuemerais @balanpaul @CodeMinion
Thanks for fork link, i will try it tomorrow or Wedneesday, i hope.

I can test because i have one on my desk.

I tell you when done.

Regards.

[CodeMinion]

Hi @alaindeseine, @PrimaelQuemerais , @balanpaul ,

Apologies for the delayed response on this. I was hoping to get a slice of time to look at this this month but it doesn't seem like I'll have the bandwidth.

If anyone can give the code on the PR (#110) a test it would help out a lot. I can then move ahead and merge it if all checks out.

Thanks in advance,

[balanpaul]

Hello @CodeMinion, @PrimaelQuemerais, @alaindeseine ,

Apologies for the late reply—we only received the printer yesterday.

We successfully completed the first print, but we received the TD-2350DSA-203, so we need to modify the implementation for this model. @PrimaelQuemerais, would it be possible to include support for additional models in the same PR?

Additionally, how can we update the iOS version as well?

Thanks!

[PrimaelQuemerais]

@balanpaul I've updated my PR can you try this?

[balanpaul]

Hello @PrimaelQuemerais

I've been running additional test cases, and at times, the connection doesn't seem to work. However, I haven't been able to identify any specific pattern causing this issue.

Additionally, I have a question regarding model naming. Shouldn't it be formatted like this?
TD_2350DSA_203 = Model._internal2("TD_2350DSA", 101, RJ_4030); ?

[PrimaelQuemerais]

Hi @balanpaul
I only have the TD-2350D so I wasn't able to try the other models.

Regarding the TD_2350DSA question you might need to change it. From my tests the dpi should not be specified here otherwise the printer won't be detected over Bluetooth.

[balanpaul]

Hello @PrimaelQuemerais @CodeMinion
Bluetooth works. On the network, it doesn't find the printer, but we saved the MAC address from Bluetooth in the cache so it also works to receive requests over the network. Would it be possible to do the same on iOS? Many thanks!

[alaindeseine]

Hi @CodeMinion @PrimaelQuemerais @balanpaul

Sorry for this period of silence, I've been overbooked on other projects.

I am resuming testing to integrate the new TD2350D printers.

For now, I'm testing with the repo of @PrimaelQuemerais, thanks for that.

@CodeMinion Do you have a plan for integrating the pull request of @PrimaelQuemerais ?

@PrimaelQuemerais Would you be ok with adding 1 or 2 paper sizes to your repo?

Thank you all.