Manchester | 26-ITP-May | Yee Man Tsang | Sprint 1 | Coursework#1335
Manchester | 26-ITP-May | Yee Man Tsang | Sprint 1 | Coursework#1335lintsang wants to merge 16 commits into
Conversation
lintsang
added
the
Needs Review
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Can you update with the rest of the mandatory sprint 1 exercises please?
LonMcGregor
added
Reviewed
lintsang
added
the
Needs Review
|
Thanks a lot for your reminder. I mistakenly missed the other folders of assignments. Now it is finished. |
It's finished. Please check. |
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work, good explanations. Some tasks need another attempt, see my comments.
|
|
||
| //TypeError: Assignment to constant variable. | ||
| //This error is caused by the wrong reassignment of variable 'age'. It is a constant that cannot be reassigned. | ||
| //So the error prompted when the second line code try to reassign the variable value. No newline at end of file |
There was a problem hiding this comment.
How would you change "const" to fix it?
| // Read the code and then answer the questions below | ||
|
|
||
| // a) How many function calls are there in this file? Write down all the lines where a function call is made | ||
| // There is 3 function calls in line 4, 5 and 10. Number() and console.log() both are the function. |
There was a problem hiding this comment.
These are function calls, good that you found them. Are there any more to find? How many in total?
| // Line 4 is calculating the quotient of the calculation (8784-remainder) divided by 60 to find the movie length in minute. That will be later used to find the display minute in the Hour:Minute:Second format. | ||
|
|
||
| // e) What do you think the variable result represents? Can you think of a better name for this variable? | ||
| // I think the original movie length is in second and this code is to calculate the display of movie length in the Hour:Minute:Second format like what what we see in a normal movie information. |
There was a problem hiding this comment.
Good explanation, what name could we give to the variable to represent this?
LonMcGregor
removed
the
Needs Review
lintsang
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
|
Thanks again for the feedback. I have recorrect all of it. |
lintsang
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
|
Good answers for this, this task is complete. However, I see you've got a message from the bot indicating some incorrect files were changed. Do you know how to resolve that? |
Sorry I mistakenly changed the Sprint 2 files. I tried to fix this but cannot find any resources from google can solve it. Reverting a commit cannot be found on my pull request. Can you give me some clue what I can do? The only solution I can think of is to close this pull request, redo all the steps in exercise and make a new pull request. However, I worried it wastes your time to review my answer all over again. |
|
@lintsang We have a brand new guide to help with this situation: https://curriculum.codeyourfuture.io/guides/reviewing/fixing/ Let me know if that makes sense or if extra guidance is needed |
lintsang
added
the
Needs Review
Many thanks for your help! This guide is very useful. |
2 participants
Learners, PR Template
Self checklist
Changelist
Follow the instruction of Sprint 1 Coursework and work on the exercises in 4 folders