Skip to content

cli: stop storing the turn's run state in chat message metadata #1583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
obadakhalili merged 1 commit into from
Oct 30, 2026
Merged

cli: stop storing the turn's run state in chat message metadata #1583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion cli/src/hooks/__tests__/use-send-message.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,6 @@ describe('useSendMessage continuation state', () => {
content: finalText,
})
expect(saved.isComplete).toBe(true)
expect(saved.metadata.runState).toEqual(finalState)
} finally {
settlePendingRuns()
await run
Expand Down
3 changes: 0 additions & 3 deletions cli/src/hooks/helpers/send-message.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,9 +487,6 @@ export const handleRunCompletion = (params: {
updater.markComplete({
...(completionTime && { completionTime }),
...(actualCredits !== undefined && { credits: actualCredits }),
metadata: {
runState,
},
})
}

Expand Down
3 changes: 2 additions & 1 deletion cli/src/types/chat.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,8 @@ export type ChatMessageMetadata = {
isCollapsed?: boolean
/** Whether the user manually opened this collapsed item */
userOpened?: boolean
/** RunState stored after completion */
/** @deprecated Never written; older transcripts may still carry it and it
* is ignored on load. */
runState?: unknown
}

Expand Down
Loading