feat(rendering): display tuning on staff lines#2742
Open
kulek1 wants to merge 4 commits into
Open
Conversation
Member
|
Good job. Seeing the overall code I just have some small performance concern as we additionally loop all staves and tracks to compute things. It would feel a lot cleaner if we would encapsulate the staff-tuning display into a glyph and wire it like this:
I think this mostly a mechanical refactoring, functionally things can mostly stay as they are (just the duplicated checks will vanish as they are all wired into the glyph creation phase). I'm happy if you attempt this refactoring, otherwise I can also take it from here 😉 |
Author
|
@Danielku15 thanks for the feedback! I've addressed your comment - I hope it looks better now. If you see any other things to improve then feel free to commit to this branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
#2446
Proposed changes
Activation:
Activation in alphaTex:
Padding is configurable:
Checklist
Further details