bugfix: bound Delta Mode PIN reconstruction - #748
Open
scgbckbone wants to merge 1 commit into
Open
scgbckbone wants to merge 1 commit into
scgbckbone wants to merge 1 commit into
Conversation
doc-hex
added
the
bootloader
doc-hex
reviewed
Sep 1, 2026
|
|
||
| for(int i=0; i<4; i++, p--) { | ||
| if(*p == '-') p--; | ||
| // A valid Delta Mode PIN must provide four digits. |
doc-hex
reviewed
Sep 1, 2026
| cursor--; | ||
|
|
||
| int here = replacement & 0xf; | ||
| int replacement_digit = replacement & 0xf; |
Contributor
There was a problem hiding this comment.
I prefer here to replacement_digit but I'm not paid by the token.
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bound bootloader Delta Mode PIN reconstruction and fail closed on malformed PIN data. Removes the unnecessary terminator write and prevents the reverse walk from moving before the buffer.
This is a defense-in-depth correctness fix, not an exploitable security issue: supported PIN entry and trick-PIN provisioning cannot produce the malformed inputs needed to reach these bounds.
Validation: Mk4 and Q pins.o compile. No Python test applies because the simulator does not execute bootloader C.