BREAK: map conservation rules to priorities - #377
Open
grayson-helmholz wants to merge 1 commit into
Open
grayson-helmholz wants to merge 1 commit into
grayson-helmholz wants to merge 1 commit into
Conversation
redeboer
added this pull request to stack #386
September 15, 2026 14:29
redeboer
self-requested a review
September 15, 2026 14:40
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
conservation_rulesandrule_prioritiesattributes #279EdgeSettingsandNodeSettingsnow carry the rules and their priorities in a single field.conservation_rulesbecame a mapping of each rule to its priority (rules with a higher priority are evaluated first), so the separaterule_prioritiesfield disappears. Asetis still accepted as input: a converter normalizes it to a mapping in which every rule gets the newDEFAULT_RULE_PRIORITY(1), but reading the attribute back always yields adict.EdgeSettings.rule_prioritiesEdgeSettings.conservation_rulesNodeSettings.rule_prioritiesNodeSettings.conservation_rulesEdgeSettings.conservation_rules: set[GraphElementRule]EdgeSettings.conservation_rules: dict[GraphElementRule, int]NodeSettings.conservation_rules: set[Rule]NodeSettings.conservation_rules: dict[Rule, int]Priorities are now attached per rule instance rather than looked up by rule type, which simplifies
filter_quantum_number_problem_set()and_get_rules_by_priority().create_interaction_settings()still derives its mappings fromEDGE_RULE_PRIORITIESandCONSERVATION_LAW_PRIORITIES, so the default interaction settings are unchanged.❗ Behavioral changes
qrules.io, a rule without a declared priority is now rendered with its effective priority1instead ofNA, and theRULESblock is emitted whenever a setting has any rules, not only when priorities were declared separately.Squash commit messages