BREAK: decouple CSPSolver from particle database - #378
Open
grayson-helmholz wants to merge 1 commit into
Open
grayson-helmholz wants to merge 1 commit into
grayson-helmholz wants to merge 1 commit into
Conversation
redeboer
added this pull request to stack #386
September 15, 2026 14:29
redeboer
self-requested a review
September 15, 2026 14:40
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CSPSolverno longer matches its solutions against a particle database. It solves for quantum numbers only, and the matching step moved to the new public functioncomplete_intermediate_states(), which takes aQNResult, itsQNProblemSet, and the allowed intermediate states. Re-validating the rules that the solver could not execute moved along with it, since those rules can only run once the intermediate states are complete.CSPSolver(allowed_intermediate_states)CSPSolver(), followed bycomplete_intermediate_states(result, problem_set, allowed_intermediate_states)solve()inqrules.workflowperforms both steps, so the high-level API is unaffected.⚙️ Enhancements
CSPSolvercan now run without a particle database at all. Its solutions carry just the quantum numbers that were solved for, which is what lets later steps work with intermediate states that no particle needs to match._insert_allowed_states()skips intermediate edges for which the solver produced no state instead of raising aKeyError, so partial solutions can be completed.Squash commit messages