Add ComfyUI-BatchPromptLoader to custom node list - #3183
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe custom-node registry now includes ChangesBatch prompt loader registration
Suggested reviewers: Merge Risk: ⚪ Minimal · up to This localized metadata-only change adds a custom node entry and introduces no actionable merge-blocking risk; it is merge-ready after normal checks and review. 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The
Please confine these to a fixed base directory (resolve the real path and verify it stays within the base). I'll re-evaluate once the paths are contained. Additionally, please write the node UI strings in English (currently the node display name and widget field labels are in Chinese). For multilingual support, refer to the locale feature: |
…UI to English Addresses maintainer review feedback on Comfy-Org/ComfyUI-Manager#3183. Path traversal: - Add _confine_to_base(), which resolves the real path (following symlinks) and verifies it stays inside the ComfyUI root directory. Applied to folder_path, log_folder and output_folder. - Previously an absolute path was trusted verbatim and relative paths could escape via '..', allowing a graph to read arbitrary files and to write or delete .json files anywhere the server could reach. - Log clearing now only removes JSON files previously written by this node (validated by the 'prompt_file' key) instead of every .json in the folder. UI localization: - Node display name and all widget labels are now English.
|
Thanks for the review — both points are addressed in 1. Path traversal (
|
|
Follow-up: the README is now in sync with this change (fd69658). The wording that allowed arbitrary absolute paths, and the out-of-tree |
|
Thanks for the review — both points are now addressed further. Narrowed path scope (per your suggestion): the allowed range is no longer the whole ComfyUI root. Each user-supplied path is now confined to its own dedicated base directory:
Implementation details:
Verified with a unit test suite (21 cases covering the three bases, legacy prefixes, and escape attempts — all passing) and an end-to-end smoke test on a fake ComfyUI tree (valid reads succeed, escape paths are rejected before any file access). Changes are on UI language: already switched to English (labels + README), as noted in my previous comment. |
Add ComfyUI-BatchPromptLoader to the ComfyUI-Manager custom node list.