Skip to content

Add Model Fetcher (comfyui-modelfetcher) - #3189

Open
KoLt-Real wants to merge 1 commit into
Comfy-Org:mainfrom
KoLt-Real:add-modelfetcher
Open

Add Model Fetcher (comfyui-modelfetcher)#3189
KoLt-Real wants to merge 1 commit into
Comfy-Org:mainfrom
KoLt-Real:add-modelfetcher

Conversation

@KoLt-Real

Copy link
Copy Markdown

Adds Model Fetcher, already published on the Comfy Registry: https://registry.comfy.org/nodes/comfyui-modelfetcher

  • Repository: https://github.com/KoLt-Real/ComfyUI-ModelFetcher
  • Registers no nodes: a top-bar button that reads the open workflow's Markdown notes, downloads the models they list into the right models/ subfolder (extra_model_paths aware, resume, HuggingFace token kept to HF hosts only), flags likely duplicates, and relinks loader nodes to copies already on disk.
  • No dependencies beyond what ComfyUI ships (requests, aiohttp); no build step; comfy node validate passes clean.

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Aug 22, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: d16ab176-1f46-43f4-a02b-649fa68ca00e

📥 Commits

Reviewing files that changed from the base of the PR and between f39cbd5 and 363fc71.

📒 Files selected for processing (1)
  • custom-node-list.json

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The custom-node registry adds the “Model Fetcher” entry. The entry identifies its repository, uses git-clone installation, and describes its workflow-note model download and loader relinking functions.

Changes

Model Fetcher registration

Layer / File(s) Summary
Add Model Fetcher registry entry
custom-node-list.json
Adds comfyui-modelfetcher with repository metadata, git-clone installation, author information, and a description of its model-fetching behavior. Mischief managed, models fetched.

Suggested reviewers: ltdrdata, mickmumpitz, muerrilla

Merge Risk: ⚪ Minimal · up to 363fc

This PR adds a localized registry entry, and no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ltdrdata

ltdrdata commented Sep 1, 2026

Copy link
Copy Markdown
Member

This pack exposes network-reachable routes with no access control: one writes files from a caller-supplied job, and a token route writes/clears a credentials file. A url is also fetched with no host allow-list.

  • downloader.py:204 (fetch), downloader.py:242,267 (write), hf_token.py:86-94,114 (token write/delete)

Please make these routes local-only, restrict the fetch to a host allow-list, and confine the write path. I'll re-evaluate once constrained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants