Skip to content

[ROCm] Integrate Comfy Kitchen HIP attention and INT8 fusions #15928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tvukovic-amd wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[ROCm] Integrate Comfy Kitchen HIP attention and INT8 fusions #15928

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
747ef68
Integrate Comfy Kitchen HIP attention and INT8 fusions
tvukovic-amd Aug 27, 2026
d789394
Guard optional fusion APIs, delegate Dynamic VRAM behavior correctly,…
tvukovic-amd Aug 27, 2026
ffe70f1
Merge branch 'master' into kitchen-hip-attention-flags
tvukovic-amd Aug 27, 2026
c7bf9da
Restore CPU flag after Lumina test setup
tvukovic-amd Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions comfy/cli_args.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,8 @@ def from_string(cls, value: str):
attn_group.add_argument("--use-split-cross-attention", action="store_true", help="Use the split cross attention optimization. Ignored when xformers is used.")
attn_group.add_argument("--use-quad-cross-attention", action="store_true", help="Use the sub-quadratic cross attention optimization . Ignored when xformers is used.")
attn_group.add_argument("--use-pytorch-cross-attention", action="store_true", help="Use the new pytorch 2.0 cross attention function.")
attn_group.add_argument("--use-kitchen-bf16-attention", action="store_true", help="Use Comfy Kitchen FP16/BF16 attention on supported AMD ROCm/HIP GPUs.")
attn_group.add_argument("--use-kitchen-int8-attention", action="store_true", help="Use Comfy Kitchen INT8 attention on supported AMD ROCm/HIP GPUs.")
attn_group.add_argument("--use-sage-attention", action="store_true", help="Use sage attention.")
attn_group.add_argument("--use-flash-attention", action="store_true", help="Use FlashAttention.")
attn_group.add_argument("--use-ck-attention", action="store_true", help="Use Comfy Kitchen attention.")
Expand Down
Loading
Loading