Repository navigation
Conversation
dendi2008
force-pushed
the
dualsense-speaker
branch
from
October 21, 2026 10:30
c9946d3 to
bb9c246
Compare
dendi2008
force-pushed
the
dualsense-speaker
branch
2 times, most recently
from
October 25, 2026 16:56
9e62d2d to
fd544ee
Compare
dendi2008
force-pushed
the
dualsense-speaker
branch
from
October 26, 2026 19:12
fd544ee to
8f2c87e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will add/dualshock speaker feature. Issue #508.
I think this is the best what we can do. Since, built-in speaker in dualshock works kinda weird outside of PS4 and only in some games and only in some cases (which we don't know how to reproduce. Most cases that I read were bugs and buit-in speaker feature was for dualsense, not dualshock). We could add support for other controllers speakers, but there's no way to check every controller speaker values by common, only seek values manualy, so only for dualshock for now. We could also write driver for that, but that will be long or we could make patch for ds4windows, but I don't know how we can connect ds4windows and impacto. My changes mostly copies how shadPS4 handles speaker feature.