Add shared GH workflows - #127
Conversation
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
| call-snapshot-job: | ||
| uses: project-ncl/shared-github-actions/.github/workflows/maven-snapshot.yml@646d9b629925d6405fb06ed1476aefd6b2cdca86 # v0.0.23 | ||
| with: | ||
| project_name: "Commonjava/atlas" |
There was a problem hiding this comment.
@rnc @patrikk0123 Add
java_version: "11"here I think? maven-pr has one, but maven-release and maven-snapshot do not. I was porting this over to kojiji, and I noticed some difference between the files.
There was a problem hiding this comment.
Huh, good spot! @patrikk0123 Yes, I think this does need it as the default is 21 otherwise.
There was a problem hiding this comment.
@patrikk0123 @rnc I guess maven-set-version, too. Not as important, because I don't think it builds, but I think for consistency we should use the same JDK?
378f984 to
2e7855b
Compare
No description provided.