Skip to content

[T3456] Add spacing between donation history list and its pager - #390

Merged
ecino merged 1 commit into
18.0from
T3456-fix-donation-quality-test
Sep 14, 2026
Merged

ecino merged 1 commit into
18.0from
T3456-fix-donation-quality-test

Conversation

@danpa32

@danpa32 danpa32 commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor

T3456 — Fix failing quality test: MyCompassion: donations

Follow-up to T3416-tax-receipt-donation-history/T3441-tax-receipt-signature-lang. compassion-switzerland, compassion-website, compassion-modules

Related PR

What changed

  1. Tax receipt renders in the viewer's interface language, not the partner's stored one (compassion-switzerland)
  2. Tax receipt overflowing to a second page (compassion-switzerland)
  • The signature <img> had no height/width cap (width: 40%, ~76mm) — capped to width: 45mm (matching anniversary_card.xml's own signature usage). Margin-left adjusted afterward too (was -15mm, pushing it into the page margin per user feedback - see below).
  • .body_text (the letter-body box) is hardcoded to min-height: 120mm whenever a signature is shown, forcing a large empty gap below "Best regards" even for the tax receipt's few short paragraphs. Added a compact_body flag (set only in tax_receipt.xml) that skips this min-height, without touching the other, longer communications that share this template and rely on the fixed height.
  • Also trimmed tax_receipt_content's four stacked <br/> before the intro heading down to one.
  1. Language mismatch on the child gift payment slip (compassion-switzerland)
  2. Pager spacing on the donation history list (compassion-website)
  3. Stale/corrupted "Date" column header in donation history (compassion-website) — DB-only fix, no commit

How to test manually

  • Donations page (/my2/donations): download the tax receipt while browsing in different interface languages — the whole PDF (logo, salutation, date, body text, signature) should consistently follow whichever language you're browsing in.
  • Once report_compassion can be upgraded again: download a gift payment slip for a sponsored child while browsing in a language different from the partner's stored profile language — labels and the child/gift communication line should match.
  • Check the tax receipt PDF is one page, with reasonable spacing between the closing text and the signature.
  • Check the "Date" column header in donation history reads correctly in French (already fixed at the DB level locally; will need the same -u --i18n-overwrite sync — or .po was already correct so a normal deploy pipeline that runs migrations properly should pick it up fine).
  • Check spacing between the donation history rows and the Prev/Next pager.

The pager buttons sat flush against the last donation row with no
top margin.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@ecino
ecino merged commit 1f6d64c into 18.0 Sep 14, 2026
1 check passed
@ecino
ecino deleted the T3456-fix-donation-quality-test branch September 14, 2026 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants