Skip to content

T3333 letter report fixes - #393

Merged
ecino merged 2 commits into
18.0from
T3333-letter-report-fixes
Sep 17, 2026
Merged

ecino merged 2 commits into
18.0from
T3333-letter-report-fixes

Conversation

@danpa32

@danpa32 danpa32 commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

T3333 — MyCompassion "write a letter" quality-test failures

Original ask

A quality test on "MyCompassion: write a letter" failed on 2026-07-22 with several defects reported from a single manual walkthrough:

  • No menu icons top right, child picture missing, child arrow selector missing, Compassion logo missing top left, on the new-letter page.
  • No margin under the "Preview"/"Send" buttons.
  • Saving a draft shows a green "letter saved" confirmation in English instead of the sponsor's language.
  • The letter preview's attached-pictures page showed "Additional pictures" in large block capitals.
  • Opening a just-sent letter from MyCompassion gave an internal server error.
  • Backend → Sponsorships → Correspondence → Letters → a letter → action wheel → "Correspondence Report" downloads the PDF instead of displaying it, on Mac.

Related PRs

CompassionCH/compassion-modules#2158

What changed

compassion-website (my_compassion)

  • ffb58fc — added a bottom margin below the Preview/Send button row (was flush against the footer) and a gap between the letter textarea and the attachments upload box below it.
  • a6ab2c1 — the autosave success toast (fires automatically on form changes, e.g. changing the template) used a raw JS string instead of _t(), unlike the near-identical toast on an explicit "Save draft" click — so it always showed in English regardless of the sponsor's language. Wrapped it and added the translation to all 8 locales my_compassion ships (da_DK, de, fi_FI, fr_CH, it, nb_NO, pl_PL, sv_SE), matching each locale's existing "draft" terminology.

The Preview/Send button row sat flush against the footer with no bottom
margin, and the text area had no gap before the attachments upload box
below it.
The autosave success toast used a raw JS string instead of _t(), unlike
the identical toast shown on an explicit "Save draft" click, so it always
displayed in English regardless of the user's language. Wrap it and add
the translation to every locale my_compassion ships.
@greptile-apps

greptile-apps Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

Safe to merge; no user-impacting defects were established in the changed letter form behavior.

What we checked:

  • T-Rex ran the requested verification; however, local artifact references were not uploaded. T-Rex

Reviews (1) · Last reviewed commit: "[T3333] Translate the autosave "Draft sa..."

@ecino
ecino merged commit 9b4e82f into 18.0 Sep 17, 2026
2 checks passed
@ecino
ecino deleted the T3333-letter-report-fixes branch September 17, 2026 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants