T3333 letter report fixes - #393
Merged
Merged
Conversation
The Preview/Send button row sat flush against the footer with no bottom margin, and the text area had no gap before the attachments upload box below it.
The autosave success toast used a raw JS string instead of _t(), unlike the identical toast shown on an explicit "Save draft" click, so it always displayed in English regardless of the user's language. Wrap it and add the translation to every locale my_compassion ships.
Contributor
|
ecino
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
T3333 — MyCompassion "write a letter" quality-test failures
Original ask
A quality test on "MyCompassion: write a letter" failed on 2026-07-22 with several defects reported from a single manual walkthrough:
Related PRs
CompassionCH/compassion-modules#2158
What changed
compassion-website(my_compassion)ffb58fc— added a bottom margin below the Preview/Send button row (was flush against the footer) and a gap between the letter textarea and the attachments upload box below it.a6ab2c1— the autosave success toast (fires automatically on form changes, e.g. changing the template) used a raw JS string instead of_t(), unlike the near-identical toast on an explicit "Save draft" click — so it always showed in English regardless of the sponsor's language. Wrapped it and added the translation to all 8 localesmy_compassionships (da_DK, de, fi_FI, fr_CH, it, nb_NO, pl_PL, sv_SE), matching each locale's existing "draft" terminology.