Repository navigation
Align invoice onboarding and branding with the CompleteTech Skills package - #1
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Second pass is pushed at 320285c: synchronized branding/handoff guidance, maintainer instructions, contributor/PR/editor standards, read-only package validation and Linux/Windows/macOS CI. Invoice-specific rendering, --no-cover onboarding, billing-only scope checks, dependencies and approval boundaries remain intact. Local common synthetic tests passed (10 parameterized test methods); original Quality and all package jobs must pass before merge. No new visual-render verification is claimed. @codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 320285cd66
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| errors.append(str(exc)) | ||
| skill = local_file(root, "SKILL.md").read_text(encoding="utf-8") | ||
| header = re.match(r"\A---\n(.*?)\n---(?:\n|\Z)", skill, re.S) | ||
| names = re.findall(r'''(?m)^name:\s*['"]?([a-z0-9-]+)['"]?\s*$''', header.group(1)) if header else [] |
There was a problem hiding this comment.
When SKILL.md uses a valid YAML inline comment such as name: demo-skill # activation key, this regex finds no name and rejects the package; conversely, because its opening and closing quotes are independent optionals, malformed values such as name: 'demo-skill" pass. The previous matcher tied the closing quote to the opening quote and allowed trailing comments, so retain those semantics to avoid rejecting valid frontmatter or accepting a malformed activation key.
AGENTS.md reference: AGENTS.md:L5-L5
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a7a3b1bfe7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| """ | ||
| text = re.sub(r"(?ms)^([`~]{3,})[^\n]*\n.*?^\1[^\n]*(?:\n|$)", "", text) | ||
| text = re.sub(r"(`+).*?\1", "", text) | ||
| pattern = r'''\[[^\]\n]*\]\([ \t]*(?:<([^>\n]+)>|([^\s()]+))(?:[ \t]+(?:"[^"\n]*"|'[^'\n]*'|\([^\n)]*\)))?[ \t]*\)''' |
There was a problem hiding this comment.
When a scanned document contains a valid Markdown link such as [guide](docs/setup(v2).md), this pattern returns no target because its unquoted destination branch forbids all parentheses. As a result, validate() reports success even when that local file is missing, undermining the newly advertised local-link check for ordinary inline links; the parser should handle balanced or escaped parentheses in destinations.
Useful? React with 👍 / 👎.
2 participants
Summary
Coordinated with CompleteTech-LLC/agentic-services-orchestrator-skill#1.
Add shared family navigation, specialist ONBOARDING.md, CONTRIBUTING.md, skill-package.json, the read-only standard-library package validator, 16 synthetic regression tests, and an independent least-privilege package workflow.
The invoice first-run example uses the bundled billing Markdown, an explicit INVOICE label, --no-cover, and output/onboarding-demo.pdf rather than overwriting committed previews. The existing invoice-only scope validator remains unchanged.
Compatibility
No existing generator, template, SKILL.md, runtime dependency, approval policy, brand asset, visibility, or registry version is changed. Billing drafts remain drafts; the package does not collect payments or approve invoices. Existing quality CI is preserved.
Validation
Shared 16-test synthetic suite passed locally. GitHub must pass full-checkout package validation and existing quality checks before merge. No local full-repository or visual-render verification is claimed because the execution environment cannot clone GitHub.