Pin github-pages to 232 to fix the Jekyll build - #112
Merged
Merged
Conversation
Unpinned, Bundler now resolves github-pages 222, which pins liquid 4.0.3. Liquid 4.0.3 calls String#tainted?, removed in Ruby 3.2, so the build fails on the Ruby 3.3 runner with "undefined method `tainted?`". github-pages 232 uses liquid 4.0.4 and jekyll 3.10.0, which build cleanly. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The deploy of #111 failed:
Gemfile.lockis gitignored, so CI resolves gem versions fresh on every run. It now resolves github-pages 222, which pins liquid 4.0.3. That version callsString#tainted?inVariable#taint_check, and Ruby removed the method in 3.2. The workflow runs Ruby 3.3, so every Liquid variable render raises. Earlier runs (last success 2026-06-23) resolved a newer github-pages whose liquid is 4.0.4.This is unrelated to the STAMINA refactor; any push to
maintoday would fail the same way.Fix
Pin
github-pagesto 232 (liquid 4.0.4, jekyll 3.10.0).Test plan
bundle lockwith the pin resolves github-pages 232 / jekyll 3.10.0 / liquid 4.0.4bundle exec jekyll buildcompletes locally with those gems; output matches the previous build,/stamina/renders all 10 talksFollow-up worth considering
Committing
Gemfile.lock(currently gitignored) would make CI builds reproducible and prevent this class of surprise.🤖 Generated with Claude Code