perf(repair): stop forcing the register import#63
Open
rubenvdlinde wants to merge 1 commit into
Open
Conversation
InitializeSettings called loadConfiguration(force: true). OpenRegister's app-level import fast-skip is gated on $force === false, so forcing re-parsed doriath's register descriptor + register.d fragments and walked every register/schema on EVERY upgrade, even when nothing changed (the shillinq twin of this bug cost 711s). Safe to drop: the version passed to OR is content-addressed (+frag.<md5>), so a content change still re-imports; OpenRegister#426 additionally makes the gate content-aware. Refs: openregister#426
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the forced-register-import sweep.
InitializeSettingsforced the OpenRegister config import (force: true), which bypasses OR's app-level fast-skip (gated on$force === false) — so doriath's register descriptor +register.dfragments were re-parsed and every register/schema walked on every upgrade, even when nothing changed. The shillinq twin of this bug cost 711s -> 1s (~70% of the whole repair).Safe to drop: the version passed to OR is content-addressed (
+frag.<md5>), so a content change still re-imports; openregister#426 additionally makes the gate content-aware.Refs: openregister#426