[CDX-491] Add _dt to recommendations module - #264
Conversation
![constructor-claude-bedrock[bot]](https://avatars.githubusercontent.com/u/9828194?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull request overview
Adds a cache-busting/timestamp query parameter (_dt) to recommendations requests, aligning the Recommendations module behavior with other request modules in the SDK.
Changes:
- Append
_dt=Date.now()to the recommendations request query params. - Extend recommendations module specs to assert
_dtis present on requests.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/modules/recommendations.js | Adds _dt to the generated recommendations URL query params. |
| spec/src/modules/recommendations.js | Updates tests to verify _dt is included in outgoing recommendations requests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Code Review
This PR adds the _dt (datetime) timestamp query parameter to the recommendations module, aligning it with search, browse, autocomplete, and quizzes modules, and fixes a capitalization mismatch in a search test fixture.
Inline comments: 2 discussions added
Overall Assessment:
Mudaafi
left a comment
Mudaafi
left a comment
There was a problem hiding this comment.
Unrelated tests failing due to timeouts from https://raw.githubusercontent.com/Constructor-io/integration-examples/main/catalog/items.csv
No description provided.