Remove a skill's grants when it is uninstalled - #563
Merged
Merged
Conversation
Uninstalling a skill deleted the skill row but left its tool grants, which are keyed by slug. A new skill created under the same slug then inherited them and was offered on the old Bots with no grant action — a quiet privilege carry-over. uninstallSkill now removes the skill's grants and the skill itself in one transaction, and a migration drops any grants already orphaned this way. Originally #558 by zopeVaibhav, folded in here with the migration renumbered from 0037 to 0040 (0037 through 0039 are the composio migrations already on main), because the fork branch could not take the change directly.
davidmckayv
requested review from
MikeRyanDev,
guidovizoso,
mxmzb and
tylerslaton
as code owners
September 15, 2026 18:12
This was referenced Sep 15, 2026
Remove a skill's grants when it is uninstalled, so a new skill under that name starts on no Bot
#558
Closed
davidmckayv
added a commit
that referenced
this pull request
Sep 15, 2026
…564) The Unreleased changelog was missing several changes that landed since v0.0.11: the Composio connector (#481), the removal of a skill's grants when it is uninstalled (#563), and the request-validation sweep that answers a malformed request with a 400 rather than coercing it or letting it through (#543-#548, #550), including the one fail-open it closed. Added, each checked against the code. The README's Governed MCP bullet named only Google Drive and Notion; Composio brokers a few hundred more apps in the catalogue now, so it says so.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Folds in #558 by @zopeVaibhav — verified: uninstalling a skill left its grants (keyed by slug), so a new skill reusing the slug inherited them.
uninstallSkillnow drops the grants and the skill in one transaction, and a migration removes any already-orphaned skill grants.The only change from #558 is the migration renumber: #558 used
0037, which collides with0037–0039(the composio migrations) already on main. It's renumbered to0040, snapshotprevIdchained to0039; the fix is data-only so the schema snapshot is unchanged (drift check passes locally). #558's own branch couldn't take the renumber (GitHub refused the maintainer push), so this lands the same work here. Closing #558 in favour of this.Credit to @zopeVaibhav.