Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An unnamed MIME part explicitly marked
Content-Disposition: attachmentis currently treated as message content. Opening the inbox or a thread can fetch that attachment unnecessarily, fail when it is unavailable, or merge attached text into the parent body.Recognize the attachment disposition token in the shared predicate used by both hydration and body extraction. Keep these parts lazy and expose a generic attachment reference when Gmail supplies an attachment ID. Forwarded messages keep their existing
.emlfallback; inline text still loads as message content.Regression tests reproduced the unwanted fetch before the fix and cover remote and embedded text, HTML and multipart attachments, disposition casing/whitespace, inbox/thread reads, and inline remote bodies.
Validation: Google tests 39/39; full suite 486 passed, 3 platform-dependent skips, 0 failed; repository lint, server/mobile/worker typechecks and server build pass. Web/iOS/Android exports passed for the same unchanged mobile/domain sources in this contribution batch. Live Google accounts were not exercised.